-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ToastPresentation
usage and use toaster
to display messages
#3573
Conversation
Vykintas, this does not hook the toaster into the MessageManager -- MessageManager.outputMessage does not open any toasts. Is that still in progress or just broken? |
I pulled and built the branch and ran ui-test-app. The messages get logged in the message center, but no toast message show up, except activity messages. |
Good progress, that should cover most cases where toasts/messages are displayed. |
@NancyMcCallB @GerardasB Would you mind checking again? I have fully replaced all toasts and added new custom activity message. If this approach looks ok, I will need to update with better description and maybe move files around? |
|
This helped! Thanks! |
yea probably. thanks for volunteering 😜 |
…ki/toasts-refactor
.../ui-test-app/src/frontend/appui/frontstages/component-examples/ComponentExamplesProvider.tsx
Outdated
Show resolved
Hide resolved
ui/appui-react/src/appui-react/messages/StatusMessageRenderer.tsx
Outdated
Show resolved
Hide resolved
Other minor fixes
ToastPresentation
usage and use toaster
to display messages
Added iTwinUI
toaster
to display the toasts.Returned old implementation on message components to get rid of
ToastPresentation
and marked them as deprecated.Added new function to register ref to animate iTwinUI toasts to.
Added few deprecated tags as suggestions to some of managers. If we agree to all these deprecations (there might be more), I'd like to also add text in jsdoc about using
toaster
to display toasts where relevant.