UI: Deprecate widget mode for status bar #3870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raplemie
changed the title
NancyMcCallB
approved these changes
Jul 21, 2022
test-apps/ui-test-app/src/frontend/appui/frontstages/LocalFileStage.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StatusBarFields
isInFooterModedeprecationPart of itwin/itwinjs-backlog#190
Similar to #3843 , but for
isInFooterModeprop.Deprecated the following:
StatusFieldProps.isInFooterMode
This should be considered always true in most places where this is used as the Widget mode will be removed.
withStatusFieldPropsOnly provides the StatusFieldProps to components, which this PR makes all deprecated. The HOC is still used by different UIProviders status bars for the time being. Finding a fix to use "either" of the HOC or the context would not give much benefit at this point, and may cause double renders on context change most of the time, so I kept it as is for now.
Removed most of its use otherwise.
withMessageCenterFieldPropsOn top of most unused
StatusFieldPropsto theMessageCentercomponent, this was also providing thetargetRefprop, which have been deprecated by usingMessageManager.registerAnimateOutToElementto result in the same behavior. Kept in the UIProvides as thewithStatusFieldPropsabove.Remove most of its use.
ConditionalFieldThis component now only make "conditions" on the deprecated
StatusFieldPropswhich will all be removed, in particular theisInFooterMode, so I made this component deprecated as well as it do not serves any purposes anymore.FooterModeFieldThis component only reason is to render it's children if
isInFooterModeis true, so I removed it. (Only internal use of ConditionalField above)FrontstagePropsThis interface is used by
FrontstageandFrontstageDef, and is already handlingtrueas its default value, it was only marked@deprecatedbut no further changes were done.ContentLayoutThis component received the
isInFooterModeprop, but wasnt actually using it (bug ?) so I only marked it deprecated as well.Remaining work*withMessageCenterFieldPropsis the only HOC remaining for this issue, #3573 will effectively remove most of it's implementation and remove the need for the HOC as well, the use should be removed and marked deprecated once the PR is completed.resolves itwin/itwinjs-backlog#190