-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression 4.9.2 where aliased ECClassId switch from returning classId to className #7279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmconne
approved these changes
Oct 18, 2024
imodeljs-admin
requested review from
a team,
aruniverse,
calebmshafer and
wgoehrig
as code owners
October 19, 2024 01:40
@Mergifyio backport release/4.9.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
…d to className (#7279) Co-authored-by: Affan Khan <khanaffan@users.noreply.github.com> Co-authored-by: imodeljs-admin <38288322+imodeljs-admin@users.noreply.github.com> Co-authored-by: Paul Connelly <22944042+pmconne@users.noreply.github.com> (cherry picked from commit 0716d56) # Conflicts: # common/config/rush/pnpm-lock.yaml # core/backend/package.json # test-apps/display-test-app/android/imodeljs-test-app/app/build.gradle # test-apps/display-test-app/ios/imodeljs-test-app/imodeljs-test-app.xcodeproj/project.pbxproj # tools/internal/ios/core-test-runner/core-test-runner.xcodeproj/project.pbxproj
khanaffan
added a commit
that referenced
this pull request
Oct 21, 2024
…d to className (#7279) Co-authored-by: Affan Khan <khanaffan@users.noreply.github.com> Co-authored-by: imodeljs-admin <38288322+imodeljs-admin@users.noreply.github.com> Co-authored-by: Paul Connelly <22944042+pmconne@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4.9.x
. This broke a user.DoNotConvertClassIdsToClassNamesWhenAliased
to reproduce previous behavior.DoNotConvertClassIdsToClassNamesWhenAliased
for concurrent query to reproduce behavior of classId returning class name when aliased to be compilable with 4.8.xFirst query that broke user is following
After current fix
imodel-native: iTwin/imodel-native#891