Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(locale): fixed typo for "monday" in arabic #1067

Merged
merged 3 commits into from
Sep 30, 2020
Merged

fix(locale): fixed typo for "monday" in arabic #1067

merged 3 commits into from
Sep 30, 2020

Conversation

AlaaZorkane
Copy link
Contributor

@AlaaZorkane AlaaZorkane commented Sep 22, 2020 •
edited
Loading

It's الإثنين instead of الإتنين

Sources:

UPDATE: It seems like other arabic countries got this problem as well, converting this into draft until I fix it in all of them.

@codecov
Copy link

codecov bot commented Sep 22, 2020 •
edited
Loading

Codecov Report

Merging #1067 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1067   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          172       172           
  Lines         1522      1547   +25     
  Branches       321       328    +7     
=========================================
+ Hits          1522      1547   +25
Impacted Files Coverage Δ
src/locale/ar-kw.js 100.00% <ø> (ø)
src/locale/ar-ma.js 100.00% <ø> (ø)
src/index.js 100.00% <0.00%> (ø)
src/plugin/utc/index.js 100.00% <0.00%> (ø)
src/plugin/timezone/index.js 100.00% <0.00%> (ø)
src/plugin/objectSupport/index.js 100.00% <0.00%> (ø)
src/plugin/advancedFormat/index.js 100.00% <0.00%> (ø)
src/locale/en-SG.js
src/locale/en-sg.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94af9af...5daef94. Read the comment docs.

@AlaaZorkane AlaaZorkane marked this pull request as draft September 22, 2020 15:45
@iamkun
Copy link
Owner

iamkun commented Sep 28, 2020

Hi, if you have finished this PR, you can remove the draft label so that it could get reviewed.

@AlaaZorkane
Copy link
Contributor Author

AlaaZorkane commented Sep 28, 2020 •
edited
Loading

Hi, if you have finished this PR, you can remove the draft label so that it could get reviewed.

Hey! Sorry for the delay, I had some work going on, I will work on it as soon as possible, which will be in the next 2 days or so ~ It's not really a big deal it's just a typo, but for middle-eastern users might look a bit weird.

@AlaaZorkane AlaaZorkane marked this pull request as ready for review September 29, 2020 19:27
iamkun
iamkun reviewed Sep 30, 2020
View reviewed changes
src/locale/ar-kw.js Outdated
@@ -3,7 +3,7 @@ import dayjs from 'dayjs'

const locale = {
name: 'ar-kw',
weekdays: 'الأحد_الإتنين_الثلاثاء_الأربعاء_الخميس_الجمعة_السبت'.split('_'),
weekdays: 'الأحد_الإثنين_الثلاثاء_الأربعاء_الخميس_الجمعة_السبت'.split('_'),
months: 'يناير_فبراير_مارس_أبريل_ماي_يونيو_يوليوز_غشت_شتنبر_أكتوبر_نونبر_دجنبر'.split('_'),
weekdaysShort: 'احد_اتنين_ثلاثاء_اربعاء_خميس_جمعة_سبت'.split('_'),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know Arabic, just a simple question, should we update this as well? Or to keep the same with https://github.com/moment/moment/blob/develop/locale/ar-kw.js

Copy link
Contributor Author

@AlaaZorkane AlaaZorkane Sep 30, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, الإتنين should be الإثنين, that's how it's spelled in Arabic, I honestly don't know where moment got these locales but if you check other Arabic countries ar_* they're all spelling it الإثنين, it's the same in all Arabic countries.

Here it is in wikipedia: https://cutt.ly/Wf9BSuk

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I really ask is should we update weekdaysShort in ar-kw as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah yes, I updated it ^^

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@iamkun iamkun merged commit 2e1e426 into iamkun:dev Sep 30, 2020
iamkun pushed a commit that referenced this pull request Oct 13, 2020
@semantic-release-bot
chore(release): 1.9.2 [skip ci]
181c647 
## [1.9.2](v1.9.1...v1.9.2) (2020-10-13)

### Bug Fixes

* add arraySupport plugin ([#1129](#1129)) ([be505c2](be505c2))
* export type of duration plugin ([#1094](#1094)) ([2c92e71](2c92e71))
* Fix LocaleData plugin longDateFormat lowercase error ([#1101](#1101)) ([7937ccd](7937ccd))
* Fix objectSupport plugin bug in UTC ([#1107](#1107)) ([fe90bb6](fe90bb6)), closes [#1105](#1105)
* fix Serbian locale grammar (sr, sr-cyrl) ([#1108](#1108)) ([cc87eff](cc87eff))
* Fix typo for "monday" in arabic ([#1067](#1067)) ([2e1e426](2e1e426))
* support dayjs.add(Duration), dayjs.subtract(Duration) ([#1099](#1099)) ([b1a0294](b1a0294))
* update Breton [br] locale relativeTime config ([#1103](#1103)) ([b038bfd](b038bfd))
* update Catalan [ca] locale ordinal ([73da380](73da380))
* update German [de] locale relativeTime config ([#1109](#1109)) ([f6e771b](f6e771b))
* update localeData plugin to add longDateFormat to global localeData ([#1106](#1106)) ([16937d1](16937d1))
* Update objectSupport plugin to return current date time while parsing empty object ([f56783e](f56783e))
@iamkun
Copy link
Owner

iamkun commented Oct 13, 2020

🎉 This PR is included in version 1.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.9.2 [skip ci]
9c3b1b4 
## [1.9.2](iamkun/dayjs@v1.9.1...v1.9.2) (2020-10-13)

### Bug Fixes

* add arraySupport plugin ([#1129](iamkun/dayjs#1129)) ([be505c2](iamkun/dayjs@be505c2))
* export type of duration plugin ([#1094](iamkun/dayjs#1094)) ([2c92e71](iamkun/dayjs@2c92e71))
* Fix LocaleData plugin longDateFormat lowercase error ([#1101](iamkun/dayjs#1101)) ([7937ccd](iamkun/dayjs@7937ccd))
* Fix objectSupport plugin bug in UTC ([#1107](iamkun/dayjs#1107)) ([fe90bb6](iamkun/dayjs@fe90bb6)), closes [#1105](iamkun/dayjs#1105)
* fix Serbian locale grammar (sr, sr-cyrl) ([#1108](iamkun/dayjs#1108)) ([cc87eff](iamkun/dayjs@cc87eff))
* Fix typo for "monday" in arabic ([#1067](iamkun/dayjs#1067)) ([2e1e426](iamkun/dayjs@2e1e426))
* support dayjs.add(Duration), dayjs.subtract(Duration) ([#1099](iamkun/dayjs#1099)) ([b1a0294](iamkun/dayjs@b1a0294))
* update Breton [br] locale relativeTime config ([#1103](iamkun/dayjs#1103)) ([b038bfd](iamkun/dayjs@b038bfd))
* update Catalan [ca] locale ordinal ([73da380](iamkun/dayjs@73da380))
* update German [de] locale relativeTime config ([#1109](iamkun/dayjs#1109)) ([f6e771b](iamkun/dayjs@f6e771b))
* update localeData plugin to add longDateFormat to global localeData ([#1106](iamkun/dayjs#1106)) ([16937d1](iamkun/dayjs@16937d1))
* Update objectSupport plugin to return current date time while parsing empty object ([f56783e](iamkun/dayjs@f56783e))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.9.2 [skip ci]
cddaa78 
## [1.9.2](iamkun/dayjs@v1.9.1...v1.9.2) (2020-10-13)

### Bug Fixes

* add arraySupport plugin ([#1129](iamkun/dayjs#1129)) ([be505c2](iamkun/dayjs@be505c2))
* export type of duration plugin ([#1094](iamkun/dayjs#1094)) ([2c92e71](iamkun/dayjs@2c92e71))
* Fix LocaleData plugin longDateFormat lowercase error ([#1101](iamkun/dayjs#1101)) ([7937ccd](iamkun/dayjs@7937ccd))
* Fix objectSupport plugin bug in UTC ([#1107](iamkun/dayjs#1107)) ([fe90bb6](iamkun/dayjs@fe90bb6)), closes [#1105](iamkun/dayjs#1105)
* fix Serbian locale grammar (sr, sr-cyrl) ([#1108](iamkun/dayjs#1108)) ([cc87eff](iamkun/dayjs@cc87eff))
* Fix typo for "monday" in arabic ([#1067](iamkun/dayjs#1067)) ([2e1e426](iamkun/dayjs@2e1e426))
* support dayjs.add(Duration), dayjs.subtract(Duration) ([#1099](iamkun/dayjs#1099)) ([b1a0294](iamkun/dayjs@b1a0294))
* update Breton [br] locale relativeTime config ([#1103](iamkun/dayjs#1103)) ([b038bfd](iamkun/dayjs@b038bfd))
* update Catalan [ca] locale ordinal ([73da380](iamkun/dayjs@73da380))
* update German [de] locale relativeTime config ([#1109](iamkun/dayjs#1109)) ([f6e771b](iamkun/dayjs@f6e771b))
* update localeData plugin to add longDateFormat to global localeData ([#1106](iamkun/dayjs#1106)) ([16937d1](iamkun/dayjs@16937d1))
* Update objectSupport plugin to return current date time while parsing empty object ([f56783e](iamkun/dayjs@f56783e))
splashwizard pushed a commit to splashwizard/tracking-time that referenced this pull request Oct 21, 2024
@semantic-release-bot
chore(release): 1.9.2 [skip ci]
4f20869 
## [1.9.2](iamkun/dayjs@v1.9.1...v1.9.2) (2020-10-13)

### Bug Fixes

* add arraySupport plugin ([#1129](iamkun/dayjs#1129)) ([be505c2](iamkun/dayjs@be505c2))
* export type of duration plugin ([#1094](iamkun/dayjs#1094)) ([2c92e71](iamkun/dayjs@2c92e71))
* Fix LocaleData plugin longDateFormat lowercase error ([#1101](iamkun/dayjs#1101)) ([7937ccd](iamkun/dayjs@7937ccd))
* Fix objectSupport plugin bug in UTC ([#1107](iamkun/dayjs#1107)) ([fe90bb6](iamkun/dayjs@fe90bb6)), closes [#1105](iamkun/dayjs#1105)
* fix Serbian locale grammar (sr, sr-cyrl) ([#1108](iamkun/dayjs#1108)) ([cc87eff](iamkun/dayjs@cc87eff))
* Fix typo for "monday" in arabic ([#1067](iamkun/dayjs#1067)) ([2e1e426](iamkun/dayjs@2e1e426))
* support dayjs.add(Duration), dayjs.subtract(Duration) ([#1099](iamkun/dayjs#1099)) ([b1a0294](iamkun/dayjs@b1a0294))
* update Breton [br] locale relativeTime config ([#1103](iamkun/dayjs#1103)) ([b038bfd](iamkun/dayjs@b038bfd))
* update Catalan [ca] locale ordinal ([73da380](iamkun/dayjs@73da380))
* update German [de] locale relativeTime config ([#1109](iamkun/dayjs#1109)) ([f6e771b](iamkun/dayjs@f6e771b))
* update localeData plugin to add longDateFormat to global localeData ([#1106](iamkun/dayjs#1106)) ([16937d1](iamkun/dayjs@16937d1))
* Update objectSupport plugin to return current date time while parsing empty object ([f56783e](iamkun/dayjs@f56783e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamkun iamkun iamkun left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlaaZorkane @iamkun