Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows to add durations to dayjs instance #1099

Merged
merged 4 commits into from
Oct 2, 2020
Merged

Allows to add durations to dayjs instance #1099

merged 4 commits into from
Oct 2, 2020

Conversation

stebogit
Copy link
Contributor

@stebogit stebogit commented Oct 1, 2020 •
edited
Loading

Fixes #1093

Now, once you've added the Duration plugin, you can

const d = dayjs('2020-10-01');
const days = dayjs.duration(2, 'days');
d.add(days).format('YYYY-MM-DD')); // 2020-10-03

@codecov
Copy link

codecov bot commented Oct 1, 2020 •
edited
Loading

Codecov Report

Merging #1099 into dev will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #1099   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          171       172    +1     
  Lines         1492      1554   +62     
  Branches       318       329   +11     
=========================================
+ Hits          1492      1554   +62
Impacted Files Coverage Δ
src/plugin/duration/index.js 100.00% <100.00%> (ø)
src/index.js 100.00% <0.00%> (ø)
src/locale/bi.js 100.00% <0.00%> (ø)
src/locale/hr.js 100.00% <0.00%> (ø)
src/locale/lt.js 100.00% <0.00%> (ø)
src/locale/pl.js 100.00% <0.00%> (ø)
src/plugin/utc/index.js 100.00% <0.00%> (ø)
src/plugin/timezone/index.js 100.00% <0.00%> (ø)
src/plugin/localeData/index.js 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c2050a...476f40b. Read the comment docs.

stebogit added a commit to stebogit/dayjs-website that referenced this pull request Oct 1, 2020
@stebogit
Updated Duration documentation
6376d87 
Ref iamkun/dayjs#1099
@stebogit stebogit mentioned this pull request Oct 1, 2020
Closed
@stebogit
Copy link
Contributor Author

stebogit commented Oct 2, 2020

Not sure why the two CI jobs have not been completed... 😞

@iamkun
Copy link
Owner

iamkun commented Oct 2, 2020

@stebogit I don't know either, I'll restart it manually.

@iamkun iamkun closed this Oct 2, 2020
@iamkun iamkun reopened this Oct 2, 2020
iamkun
iamkun reviewed Oct 2, 2020
View reviewed changes
src/plugin/duration/index.js Outdated Show resolved Hide resolved
@stebogit
Copy link
Contributor Author

stebogit commented Oct 2, 2020

here we go @iamkun

@iamkun
Copy link
Owner

iamkun commented Oct 2, 2020

Cool

@iamkun iamkun merged commit b1a0294 into iamkun:dev Oct 2, 2020
iamkun pushed a commit that referenced this pull request Oct 13, 2020
@semantic-release-bot
chore(release): 1.9.2 [skip ci]
181c647 
## [1.9.2](v1.9.1...v1.9.2) (2020-10-13)

### Bug Fixes

* add arraySupport plugin ([#1129](#1129)) ([be505c2](be505c2))
* export type of duration plugin ([#1094](#1094)) ([2c92e71](2c92e71))
* Fix LocaleData plugin longDateFormat lowercase error ([#1101](#1101)) ([7937ccd](7937ccd))
* Fix objectSupport plugin bug in UTC ([#1107](#1107)) ([fe90bb6](fe90bb6)), closes [#1105](#1105)
* fix Serbian locale grammar (sr, sr-cyrl) ([#1108](#1108)) ([cc87eff](cc87eff))
* Fix typo for "monday" in arabic ([#1067](#1067)) ([2e1e426](2e1e426))
* support dayjs.add(Duration), dayjs.subtract(Duration) ([#1099](#1099)) ([b1a0294](b1a0294))
* update Breton [br] locale relativeTime config ([#1103](#1103)) ([b038bfd](b038bfd))
* update Catalan [ca] locale ordinal ([73da380](73da380))
* update German [de] locale relativeTime config ([#1109](#1109)) ([f6e771b](f6e771b))
* update localeData plugin to add longDateFormat to global localeData ([#1106](#1106)) ([16937d1](16937d1))
* Update objectSupport plugin to return current date time while parsing empty object ([f56783e](f56783e))
@iamkun
Copy link
Owner

iamkun commented Oct 13, 2020

🎉 This PR is included in version 1.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mfogel mfogel mentioned this pull request Oct 20, 2020
Merged
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.9.2 [skip ci]
9c3b1b4 
## [1.9.2](iamkun/dayjs@v1.9.1...v1.9.2) (2020-10-13)

### Bug Fixes

* add arraySupport plugin ([#1129](iamkun/dayjs#1129)) ([be505c2](iamkun/dayjs@be505c2))
* export type of duration plugin ([#1094](iamkun/dayjs#1094)) ([2c92e71](iamkun/dayjs@2c92e71))
* Fix LocaleData plugin longDateFormat lowercase error ([#1101](iamkun/dayjs#1101)) ([7937ccd](iamkun/dayjs@7937ccd))
* Fix objectSupport plugin bug in UTC ([#1107](iamkun/dayjs#1107)) ([fe90bb6](iamkun/dayjs@fe90bb6)), closes [#1105](iamkun/dayjs#1105)
* fix Serbian locale grammar (sr, sr-cyrl) ([#1108](iamkun/dayjs#1108)) ([cc87eff](iamkun/dayjs@cc87eff))
* Fix typo for "monday" in arabic ([#1067](iamkun/dayjs#1067)) ([2e1e426](iamkun/dayjs@2e1e426))
* support dayjs.add(Duration), dayjs.subtract(Duration) ([#1099](iamkun/dayjs#1099)) ([b1a0294](iamkun/dayjs@b1a0294))
* update Breton [br] locale relativeTime config ([#1103](iamkun/dayjs#1103)) ([b038bfd](iamkun/dayjs@b038bfd))
* update Catalan [ca] locale ordinal ([73da380](iamkun/dayjs@73da380))
* update German [de] locale relativeTime config ([#1109](iamkun/dayjs#1109)) ([f6e771b](iamkun/dayjs@f6e771b))
* update localeData plugin to add longDateFormat to global localeData ([#1106](iamkun/dayjs#1106)) ([16937d1](iamkun/dayjs@16937d1))
* Update objectSupport plugin to return current date time while parsing empty object ([f56783e](iamkun/dayjs@f56783e))
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.9.2 [skip ci]
cddaa78 
## [1.9.2](iamkun/dayjs@v1.9.1...v1.9.2) (2020-10-13)

### Bug Fixes

* add arraySupport plugin ([#1129](iamkun/dayjs#1129)) ([be505c2](iamkun/dayjs@be505c2))
* export type of duration plugin ([#1094](iamkun/dayjs#1094)) ([2c92e71](iamkun/dayjs@2c92e71))
* Fix LocaleData plugin longDateFormat lowercase error ([#1101](iamkun/dayjs#1101)) ([7937ccd](iamkun/dayjs@7937ccd))
* Fix objectSupport plugin bug in UTC ([#1107](iamkun/dayjs#1107)) ([fe90bb6](iamkun/dayjs@fe90bb6)), closes [#1105](iamkun/dayjs#1105)
* fix Serbian locale grammar (sr, sr-cyrl) ([#1108](iamkun/dayjs#1108)) ([cc87eff](iamkun/dayjs@cc87eff))
* Fix typo for "monday" in arabic ([#1067](iamkun/dayjs#1067)) ([2e1e426](iamkun/dayjs@2e1e426))
* support dayjs.add(Duration), dayjs.subtract(Duration) ([#1099](iamkun/dayjs#1099)) ([b1a0294](iamkun/dayjs@b1a0294))
* update Breton [br] locale relativeTime config ([#1103](iamkun/dayjs#1103)) ([b038bfd](iamkun/dayjs@b038bfd))
* update Catalan [ca] locale ordinal ([73da380](iamkun/dayjs@73da380))
* update German [de] locale relativeTime config ([#1109](iamkun/dayjs#1109)) ([f6e771b](iamkun/dayjs@f6e771b))
* update localeData plugin to add longDateFormat to global localeData ([#1106](iamkun/dayjs#1106)) ([16937d1](iamkun/dayjs@16937d1))
* Update objectSupport plugin to return current date time while parsing empty object ([f56783e](iamkun/dayjs@f56783e))
splashwizard pushed a commit to splashwizard/tracking-time that referenced this pull request Oct 21, 2024
@semantic-release-bot
chore(release): 1.9.2 [skip ci]
4f20869 
## [1.9.2](iamkun/dayjs@v1.9.1...v1.9.2) (2020-10-13)

### Bug Fixes

* add arraySupport plugin ([#1129](iamkun/dayjs#1129)) ([be505c2](iamkun/dayjs@be505c2))
* export type of duration plugin ([#1094](iamkun/dayjs#1094)) ([2c92e71](iamkun/dayjs@2c92e71))
* Fix LocaleData plugin longDateFormat lowercase error ([#1101](iamkun/dayjs#1101)) ([7937ccd](iamkun/dayjs@7937ccd))
* Fix objectSupport plugin bug in UTC ([#1107](iamkun/dayjs#1107)) ([fe90bb6](iamkun/dayjs@fe90bb6)), closes [#1105](iamkun/dayjs#1105)
* fix Serbian locale grammar (sr, sr-cyrl) ([#1108](iamkun/dayjs#1108)) ([cc87eff](iamkun/dayjs@cc87eff))
* Fix typo for "monday" in arabic ([#1067](iamkun/dayjs#1067)) ([2e1e426](iamkun/dayjs@2e1e426))
* support dayjs.add(Duration), dayjs.subtract(Duration) ([#1099](iamkun/dayjs#1099)) ([b1a0294](iamkun/dayjs@b1a0294))
* update Breton [br] locale relativeTime config ([#1103](iamkun/dayjs#1103)) ([b038bfd](iamkun/dayjs@b038bfd))
* update Catalan [ca] locale ordinal ([73da380](iamkun/dayjs@73da380))
* update German [de] locale relativeTime config ([#1109](iamkun/dayjs#1109)) ([f6e771b](iamkun/dayjs@f6e771b))
* update localeData plugin to add longDateFormat to global localeData ([#1106](iamkun/dayjs#1106)) ([16937d1](iamkun/dayjs@16937d1))
* Update objectSupport plugin to return current date time while parsing empty object ([f56783e](iamkun/dayjs@f56783e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamkun iamkun iamkun left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dayjs().add(Duration) API
2 participants
@stebogit @iamkun