Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sk.js (fixes #831) #833

Merged
merged 1 commit into from
Mar 14, 2020
Merged

Fix sk.js (fixes #831) #833

merged 1 commit into from
Mar 14, 2020

Conversation

tukusejssirs
Copy link
Contributor

  • Add functions to generate correct noun for time periods (based on cs.js);
  • Add sk.test.js (based on cs.test.js);
  • Fix a comment in cs.test.js.

@tukusejssirs
Copy link
Contributor Author

I wish @prantlf would check the sk.js if I got his function right.

@tukusejssirs tukusejssirs changed the title Fix sk.js Fix sk.js (fixes #831) Mar 12, 2020
@codecov
Copy link

codecov bot commented Mar 12, 2020 •
edited
Loading

Codecov Report

Merging #833 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #833   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files       158    158           
  Lines      1165   1189   +24     
  Branches    222    240   +18     
===================================
+ Hits       1165   1189   +24
Impacted Files Coverage Δ
src/locale/cs.js 100% <ø> (ø) ⬆️
src/locale/sk.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9b8945...416d0c7. Read the comment docs.

@tukusejssirs
Copy link
Contributor Author

Current Travis builds fail because of the following error:

    Expected value to be:
      "za pár sekúnd"
    Received:
      "o pár sekúnd"

The preposition za in the sense of in in in a minute is a czechism (a word or usage borrowed from the Czech language), therefore the moment’s za pár sekúnd is correct in Czech, and incorrect in Slovak. In Slovak, the correct preposition is o in the phrase.

@tukusejssirs tukusejssirs mentioned this pull request Mar 12, 2020
Closed
@tukusejssirs tukusejssirs force-pushed the fix_sk.js branch 2 times, most recently from 454191d to 034d16a Compare March 13, 2020 11:26
@iamkun
Copy link
Owner

iamkun commented Mar 13, 2020

Hi, one es-lint error

dayjs/src/locale/sk.js
  71:23  error  Multiple spaces found before '// Should be `...'  no-multi-spaces

@iamkun
Copy link
Owner

iamkun commented Mar 13, 2020 •
edited
Loading

Also yearStart 4, see #831 (comment)

@tukusejssirs
Fix sk.js
416d0c7 
- Add functions to generate correct noun for time periods (based on `cs.js`);
- Add `sk.test.js` (based on `cs.test.js`);
- Add `yearStart 4` to `cs.js` and `sk.js`;
- Fix a comment in `cs.test.js`.
@tukusejssirs
Copy link
Contributor Author

Okay, now it should be okay (all checks passed).

Thank you for your time and help. You would fix this much quickly than me. 😃

@iamkun
Copy link
Owner

iamkun commented Mar 14, 2020

Cheers!

@iamkun iamkun merged commit f0d451f into iamkun:dev Mar 14, 2020
@iamkun iamkun mentioned this pull request Mar 14, 2020
Closed
iamkun pushed a commit that referenced this pull request Mar 16, 2020
@semantic-release-bot
chore(release): 1.8.23 [skip ci]
90eae15 
## [1.8.23](v1.8.22...v1.8.23) (2020-03-16)

### Bug Fixes

* Add Chinese (zh) locale ([f9b8945](f9b8945))
* Fix IsoWeek plugin typescript definition ([#828](#828)) ([30aab0c](30aab0c))
* Update Arabic (ar) locale relative time ([#836](#836)) ([14044c6](14044c6))
* Update Slovak (sk) locale,  Czech (cs) locale ([#833](#833)) ([f0d451f](f0d451f))
* Update Thai (th) locale relativeTime ([#826](#826)) ([63b7c03](63b7c03)), closes [#816](#816)
@iamkun
Copy link
Owner

iamkun commented Mar 16, 2020

🎉 This PR is included in version 1.8.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

epszaw pushed a commit to epszaw/dayjs that referenced this pull request Apr 7, 2020
@semantic-release-bot
chore(release): 1.8.23 [skip ci]
7e2dcc0 
## [1.8.23](iamkun/dayjs@v1.8.22...v1.8.23) (2020-03-16)

### Bug Fixes

* Add Chinese (zh) locale ([f9b8945](iamkun@f9b8945))
* Fix IsoWeek plugin typescript definition ([iamkun#828](iamkun#828)) ([30aab0c](iamkun@30aab0c))
* Update Arabic (ar) locale relative time ([iamkun#836](iamkun#836)) ([14044c6](iamkun@14044c6))
* Update Slovak (sk) locale,  Czech (cs) locale ([iamkun#833](iamkun#833)) ([f0d451f](iamkun@f0d451f))
* Update Thai (th) locale relativeTime ([iamkun#826](iamkun#826)) ([63b7c03](iamkun@63b7c03)), closes [iamkun#816](iamkun#816)
This was referenced Apr 8, 2020
Merged
Open
@snyk-bot snyk-bot mentioned this pull request May 3, 2020
Closed
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.23 [skip ci]
953a5c4 
## [1.8.23](iamkun/dayjs@v1.8.22...v1.8.23) (2020-03-16)

### Bug Fixes

* Add Chinese (zh) locale ([f9b8945](iamkun/dayjs@f9b8945))
* Fix IsoWeek plugin typescript definition ([#828](iamkun/dayjs#828)) ([30aab0c](iamkun/dayjs@30aab0c))
* Update Arabic (ar) locale relative time ([#836](iamkun/dayjs#836)) ([14044c6](iamkun/dayjs@14044c6))
* Update Slovak (sk) locale,  Czech (cs) locale ([#833](iamkun/dayjs#833)) ([f0d451f](iamkun/dayjs@f0d451f))
* Update Thai (th) locale relativeTime ([#826](iamkun/dayjs#826)) ([63b7c03](iamkun/dayjs@63b7c03)), closes [#816](iamkun/dayjs#816)
andrewhood125ruhuc added a commit to andrewhood125ruhuc/SidRH2 that referenced this pull request May 10, 2022
@andrewhood125ruhuc
chore(release): 1.8.23 [skip ci]
e0606a1 
## [1.8.23](iamkun/dayjs@v1.8.22...v1.8.23) (2020-03-16)

### Bug Fixes

* Add Chinese (zh) locale ([f9b8945](iamkun/dayjs@f9b8945))
* Fix IsoWeek plugin typescript definition ([#828](iamkun/dayjs#828)) ([30aab0c](iamkun/dayjs@30aab0c))
* Update Arabic (ar) locale relative time ([#836](iamkun/dayjs#836)) ([14044c6](iamkun/dayjs@14044c6))
* Update Slovak (sk) locale,  Czech (cs) locale ([#833](iamkun/dayjs#833)) ([f0d451f](iamkun/dayjs@f0d451f))
* Update Thai (th) locale relativeTime ([#826](iamkun/dayjs#826)) ([63b7c03](iamkun/dayjs@63b7c03)), closes [#816](iamkun/dayjs#816)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tukusejssirs @iamkun