fix: normalizeNode (#5311)

* fix * Create large-worms-jog.md * Update large-worms-jog.md * Update large-worms-jog.md * Update large-worms-jog.md * fix
ianstormtaylor · Feb 23, 2023 · 0ac72a6 · 0ac72a6
1 parent b94254d
commit 0ac72a6
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 7 deletions.
diff --git a/.changeset/large-worms-jog.md b/.changeset/large-worms-jog.md
@@ -0,0 +1,5 @@
+---
+'slate': patch
+---
+
+Fix #5295 regression. `editor.shouldNormalize` new option: `initialDirtyPathsLength: number`
diff --git a/docs/api/nodes/editor.md b/docs/api/nodes/editor.md
@@ -420,7 +420,7 @@ Check if a value is a void `Element` object.
 
 Override this method to prevent normalizing the editor.
 
-Options: `{ iteration: number; dirtyPaths: Path[]; operation?: Operation(entry: NodeEntry, { operation }`
+Options: `{ dirtyPaths: Path[]; initialDirtyPathsLength: number; iteration: number; operation?: Operation }`
 
 ### Callback method
 

diff --git a/packages/slate/src/create-editor.ts b/packages/slate/src/create-editor.ts
@@ -414,8 +414,8 @@ export const createEditor = (): Editor => {
       }
     },
 
-    shouldNormalize: ({ iteration, dirtyPaths }) => {
-      const maxIterations = dirtyPaths.length * 42 // HACK: better way?
+    shouldNormalize: ({ iteration, initialDirtyPathsLength }) => {
+      const maxIterations = initialDirtyPathsLength * 42 // HACK: better way?
 
       if (iteration > maxIterations) {
         throw new Error(

diff --git a/packages/slate/src/interfaces/editor.ts b/packages/slate/src/interfaces/editor.ts
@@ -85,6 +85,7 @@ export interface BaseEditor {
     operation,
   }: {
     iteration: number
+    initialDirtyPathsLength: number
     dirtyPaths: Path[]
     operation?: Operation
   }) => boolean
@@ -1072,15 +1073,16 @@ export const Editor: EditorInterface = {
         }
       }
 
-      const dirtyPaths = getDirtyPaths(editor)
-
+      let dirtyPaths = getDirtyPaths(editor)
+      const initialDirtyPathsLength = dirtyPaths.length
       let iteration = 0
 
-      while (getDirtyPaths(editor).length !== 0) {
+      while (dirtyPaths.length !== 0) {
         if (
           !editor.shouldNormalize({
+            dirtyPaths,
             iteration,
-            dirtyPaths: getDirtyPaths(editor),
+            initialDirtyPathsLength,
             operation,
           })
         ) {
@@ -1095,6 +1097,7 @@ export const Editor: EditorInterface = {
           editor.normalizeNode(entry, { operation })
         }
         iteration++
+        dirtyPaths = getDirtyPaths(editor)
       }
     })
   },