Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: normalizeNode #5311

Merged
merged 6 commits into from
Feb 23, 2023
Merged

fix: normalizeNode #5311

merged 6 commits into from
Feb 23, 2023

Conversation

zbeyens
Copy link
Contributor

@zbeyens zbeyens commented Feb 23, 2023 •
edited
Loading

Description
The maximum number of iterations should be computed before the while loop, not inside.

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 95f4457

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@zbeyens zbeyens marked this pull request as ready for review February 23, 2023 17:50
@dylans dylans merged commit 0ac72a6 into ianstormtaylor:main Feb 23, 2023
@github-actions github-actions bot mentioned this pull request Feb 23, 2023
Merged
@zbeyens zbeyens deleted the fix/max-iterations-normalize branch February 23, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcbevans rcbevans rcbevans left review comments

@dylans dylans dylans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zbeyens @dylans @rcbevans