fix: allow copying from editable void input (#5369)

ianstormtaylor · Mar 17, 2023 · 556a456 · 556a456
1 parent a9c0e37
commit 556a456
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/.changeset/funny-students-sparkle.md b/.changeset/funny-students-sparkle.md
@@ -0,0 +1,5 @@
+---
+'slate-react': patch
+---
+
+Allow copying from editable void input
diff --git a/packages/slate-react/src/components/editable.tsx b/packages/slate-react/src/components/editable.tsx
@@ -1157,7 +1157,8 @@ export const Editable = (props: EditableProps) => {
               (event: React.ClipboardEvent<HTMLDivElement>) => {
                 if (
                   ReactEditor.hasSelectableTarget(editor, event.target) &&
-                  !isEventHandled(event, attributes.onCopy)
+                  !isEventHandled(event, attributes.onCopy) &&
+                  !isDOMEventTargetInput(event)
                 ) {
                   event.preventDefault()
                   ReactEditor.setFragmentData(
@@ -1174,7 +1175,8 @@ export const Editable = (props: EditableProps) => {
                 if (
                   !readOnly &&
                   ReactEditor.hasSelectableTarget(editor, event.target) &&
-                  !isEventHandled(event, attributes.onCut)
+                  !isEventHandled(event, attributes.onCut) &&
+                  !isDOMEventTargetInput(event)
                 ) {
                   event.preventDefault()
                   ReactEditor.setFragmentData(
@@ -1736,6 +1738,21 @@ export const isEventHandled = <
   return event.isDefaultPrevented() || event.isPropagationStopped()
 }
 
+/**
+ * Check if the event's target is an input element
+ */
+export const isDOMEventTargetInput = <
+  EventType extends React.SyntheticEvent<unknown, unknown>
+>(
+  event: EventType
+) => {
+  return (
+    isDOMNode(event.target) &&
+    (event.target instanceof HTMLInputElement ||
+      event.target instanceof HTMLTextAreaElement)
+  )
+}
+
 /**
  * Check if a DOM event is overrided by a handler.
  */