fix: allow copying from editable void input #5369
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Copying from an editable void ends up with the whole void element being copied instead of the selected text only. I added a fix so that, when the target of the event is an input field it won't apply the regular Slate logic for copying and instead will just rely on the default browser's functionality.
You'll notice in the video that there is still a not-ideal use case where, if a section of text is selected from an editable void it still ends up copying the whole element, not just the text. This kind of approach is useful to enable, for example, copying a non-editable void element such as a mention. Let me know please if someone has a better idea of how to better handle it.
Issue
Fixes: #5366
Example
copy-from-editable-void.mov
Context
Checks
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)yarn changeset add
.)