Fix performance issue with renderPlaceholder
#5339
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #5310 introduced a performance issue when typing in large documents, caused by adding
renderPlaceholder
touseMemo
inelement.tsx
. This PR fixes that performance issue by wrapping the defaultrenderPlaceholder
in auseCallback
.In addition, all custom
renderPlaceholder
functions passed toEditable
should also be wrapped inuseCallback
.Issue
Fixes: #5335
Checks
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)yarn changeset add
.)