Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance issue with renderPlaceholder #5339

Merged

Conversation

12joan
Copy link
Contributor

@12joan 12joan commented Mar 6, 2023

Description
PR #5310 introduced a performance issue when typing in large documents, caused by adding renderPlaceholder to useMemo in element.tsx. This PR fixes that performance issue by wrapping the default renderPlaceholder in a useCallback.

In addition, all custom renderPlaceholder functions passed to Editable should also be wrapped in useCallback.

Issue
Fixes: #5335

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2023

🦋 Changeset detected

Latest commit: 33b6352

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dylans dylans merged commit 62f8ddd into ianstormtaylor:main Mar 6, 2023
@github-actions github-actions bot mentioned this pull request Mar 6, 2023
@12joan 12joan deleted the fix/renderPlaceholder-performance branch March 6, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slate-react: performance regression on v0.91.4
3 participants