Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-4853: Deprecated Ibexa\Core\MVC\Symfony\Locale::convertToEz method #245

Merged
merged 2 commits into from
Jul 17, 2023
Merged

IBX-4853: Deprecated Ibexa\Core\MVC\Symfony\Locale::convertToEz method #245

merged 2 commits into from
Jul 17, 2023

Conversation

konradoboza
Copy link
Contributor

Question Answer
JIRA issue IBX-4853
Type bug
Target Ibexa version v4.5, 4.6
BC breaks no

I also took the liberty to refactor corresponding test case a little.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@konradoboza konradoboza added Bug Something isn't working Ready for review labels Jul 7, 2023
@konradoboza konradoboza requested review from alongosz and a team July 7, 2023 11:11
@konradoboza konradoboza self-assigned this Jul 7, 2023
@konradoboza konradoboza requested review from alongosz and a team July 7, 2023 11:25
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alongosz alongosz requested a review from a team July 7, 2023 11:59
adamwojs
adamwojs reviewed Jul 7, 2023
View reviewed changes
Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I belive convertToEz method should be marked as deprecated

@konradoboza
Copy link
Contributor Author

@adamwojs https://github.com/ibexa/core/pull/245/files#diff-278cac33a27dab0346ef6fa107940219f1dbc29b7828c96b7813cae5b8c5e7acR22

@bogusez bogusez self-assigned this Jul 17, 2023
@alongosz alongosz merged commit 7b3f233 into 4.5 Jul 17, 2023
@alongosz alongosz deleted the ibx-4853-rebrand-locale-converter-method branch July 17, 2023 12:44
@konradoboza konradoboza mentioned this pull request Aug 1, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs left review comments

@bogusez bogusez bogusez approved these changes

@ViniTou ViniTou ViniTou approved these changes

@ciastektk ciastektk ciastektk approved these changes

@alongosz alongosz alongosz approved these changes

@kisztof kisztof kisztof approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working QA approved Ready for MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@konradoboza @adamwojs @kisztof @alongosz @ciastektk @ViniTou @bogusez @mikadamczyk @Steveb-p