Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed deprecating convertToEz method #253

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Fixed deprecating convertToEz method #253

merged 2 commits into from
Aug 1, 2023

Conversation

konradoboza
Copy link
Contributor

@konradoboza konradoboza commented Aug 1, 2023 •
edited
Loading

Question Answer
JIRA issue -
Type bug
Target Ibexa version v4.5
BC breaks no

As @adamwojs correctly observed, we need to mark a proper method as deprecated. This is a followup for #245 where the wrong one was described as such.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@konradoboza konradoboza added Bug Something isn't working Ready for review labels Aug 1, 2023
@konradoboza konradoboza self-assigned this Aug 1, 2023
@konradoboza konradoboza requested review from alongosz and a team August 1, 2023 06:26
@ciastektk ciastektk requested a review from a team August 1, 2023 06:28
@konradoboza konradoboza requested a review from webhdx August 1, 2023 07:22
@konradoboza konradoboza force-pushed the deprecate-convert-to-ez-method branch from 96b44b1 to b20f5c2 Compare August 1, 2023 08:09
@konradoboza konradoboza requested a review from alongosz August 1, 2023 08:09
@konradoboza konradoboza force-pushed the deprecate-convert-to-ez-method branch from b20f5c2 to 5ec3f51 Compare August 1, 2023 08:10
@konradoboza konradoboza force-pushed the deprecate-convert-to-ez-method branch from 5ec3f51 to b77949a Compare August 1, 2023 08:12
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alongosz alongosz merged commit 8804d46 into 4.5 Aug 1, 2023
@alongosz alongosz deleted the deprecate-convert-to-ez-method branch August 1, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViniTou ViniTou ViniTou approved these changes

@webhdx webhdx webhdx approved these changes

@ciastektk ciastektk ciastektk approved these changes

@alongosz alongosz alongosz approved these changes

@kisztof kisztof kisztof approved these changes

Assignees

@kisztof kisztof

@mikadamczyk mikadamczyk

@alongosz alongosz

@konradoboza konradoboza

Labels
Bug Something isn't working Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@konradoboza @kisztof @alongosz @ciastektk @webhdx @ViniTou @mikadamczyk