IBX-5981: Fixed handling multiple custom classes (#95)

ibexa · Jun 29, 2023 · c223ef0 · c223ef0
1 parent cd54c30
commit c223ef0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/bundle/Resources/public/js/CKEditor/custom-attributes/custom-attributes-command.js b/src/bundle/Resources/public/js/CKEditor/custom-attributes/custom-attributes-command.js
@@ -28,7 +28,7 @@ class IbexaCustomAttributesCommand extends Command {
             const hasOwnCustomClasses =
                 elementCustomClassesConfig &&
                 selectedCustomClasses
-                    .split()
+                    .split(' ')
                     .every((selectedCustomClass) => elementCustomClassesConfig.choices.includes(selectedCustomClass));
 
             if (elementName === modelElement.name || hasOwnCustomClasses) {

diff --git a/src/bundle/Resources/public/js/CKEditor/custom-attributes/ui/custom-attributes-form-view.js b/src/bundle/Resources/public/js/CKEditor/custom-attributes/ui/custom-attributes-form-view.js
@@ -209,9 +209,8 @@ class IbexaCustomAttributesFormView extends View {
         addListToDropdown(labeledDropdown.fieldView, itemsList);
 
         this.listenTo(labeledDropdown.fieldView, 'execute', (event) => {
-            const value = config.multiple
-                ? [...new Set([...labeledDropdown.fieldView.element.value.split(','), event.source.value])].join(',')
-                : event.source.value;
+            const alreadySelectedValues = labeledDropdown.fieldView.element.value ? labeledDropdown.fieldView.element.value.split(' ') : [];
+            const value = config.multiple ? [...new Set([...alreadySelectedValues, event.source.value])].join(' ') : event.source.value;
 
             labeledDropdown.fieldView.buttonView.set({
                 label: value,

diff --git a/src/bundle/Resources/public/scss/_balloon-form.scss b/src/bundle/Resources/public/scss/_balloon-form.scss
@@ -25,6 +25,7 @@
                     .ck-button.ck-dropdown__button {
                         .ck-button__label {
                             width: calculateRem(198px);
+                            display: inline-block;
                         }
                     }
                 }