-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-5981: Fixed handling multiple custom classes #95
Conversation
const value = config.multiple | ||
? [...new Set([...labeledDropdown.fieldView.element.value.split(','), event.source.value])].join(',') | ||
: event.source.value; | ||
const alreadySelectedValues = labeledDropdown.fieldView.element.value ? labeledDropdown.fieldView.element.value.split(',') : []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can use optional chaining?
const alreadySelectedValues = labeledDropdown.fieldView.element.value ? labeledDropdown.fieldView.element.value.split(',') : []; | |
const alreadySelectedValues = labeledDropdown.fieldView.element.value.split?.(',') ?? []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When using following config
values are being carried over between classes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments above.
Additional feedback from customer: https://jsd.ez.no/browse/CS-11138?focusedCommentId=276759&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-276759 Confirmed commas are present in page source. |
e5e9df1
to
4101ce1
Compare
@micszo all issues should be fixed. Please note there is another PR ibexa/admin-ui#828 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing all the issues!
QA Approved on Ibexa Experience 4.5.1-dev.
Requires: ibexa/admin-ui#828
TODO:
$ composer fix-cs
).