IBX-8342: Fixed creating tables in Online Editor #168
Conversation
alongosz
changed the title
| @@ -154,11 +154,6 @@ | |||
| } | |||
|
|
|||
| .ck-toolbar__items { | |||
| .ck-button { | |||
| padding: calculateRem(8px); | |||
There was a problem hiding this comment.
I believe this will change the look of all buttons in the toolbar, I don't think we want to change the design here.
There was a problem hiding this comment.
@dew326 Hi :) Could please be more precise? How should the design be ? This toolbar is customisable, new buttons can be added on the fly
See image. Thx
There was a problem hiding this comment.
Yeah, screenshot shows exactly what I meant. The spaces between buttons are smaller after the change.
There was a problem hiding this comment.
Is this ok ?
If so check PR update
There was a problem hiding this comment.
There is no space between table button and the line on the right.
And margin will probably make that space is not clickable, padding is better because the click area is bigger.
There was a problem hiding this comment.
.ck-button {
padding: calculateRem(8px);
margin: 0;
&.ck-insert-table-dropdown-grid-box {
padding: 0;
margin: var(--ck-insert-table-dropdown-box-margin);
}
}I think this should do the trick to keep current styling of toolbar and fix the table grid.
| @@ -154,11 +154,6 @@ | |||
| } | |||
|
|
|||
| .ck-toolbar__items { | |||
| .ck-button { | |||
| padding: calculateRem(8px); | |||
There was a problem hiding this comment.
.ck-button {
padding: calculateRem(8px);
margin: 0;
&.ck-insert-table-dropdown-grid-box {
padding: 0;
margin: var(--ck-insert-table-dropdown-box-margin);
}
}I think this should do the trick to keep current styling of toolbar and fix the table grid.
|
| padding: 0; | ||
| margin: var(--ck-insert-table-dropdown-box-margin); | ||
| } | ||
| } |
lionelakpagni
force-pushed
the
fix_table_creation_IBX-8342
branch
from
bcc64f1 to
a7d8d55
Compare
|
Description:
Fix issue IBX8342 issue on table in rich text
For QA:
Documentation: