Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8342: Fixed creating tables in Online Editor #168

Merged
merged 5 commits into from
Jul 26, 2024
Merged

IBX-8342: Fixed creating tables in Online Editor #168

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
48bd6c8
Fix issue IBX8342 issue on table in rich text
Jun 10, 2024
8f32c56
Addin margin to button elements
Jun 14, 2024
b4604da
using padding instead of margin
Jun 18, 2024
ebdafa0
setting bigger icons
Jun 19, 2024
a7d8d55
updatin scss
Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/bundle/Resources/public/scss/_balloon-form.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,12 @@
.ck-button {
padding: calculateRem(8px);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this will change the look of all buttons in the toolbar, I don't think we want to change the design here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dew326 Hi :) Could please be more precise? How should the design be ? This toolbar is customisable, new buttons can be added on the fly
See image. Thx
image

Copy link
Contributor

@dew326 dew326 Jun 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, screenshot shows exactly what I meant. The spaces between buttons are smaller after the change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ok ?
image
If so check PR update

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no space between table button and the line on the right.
And margin will probably make that space is not clickable, padding is better because the click area is bigger.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

                .ck-button {
                    padding: calculateRem(8px);
                    margin: 0;

                    &.ck-insert-table-dropdown-grid-box {
                        padding: 0;
                        margin: var(--ck-insert-table-dropdown-box-margin);
                    }
                }

I think this should do the trick to keep current styling of toolbar and fix the table grid.

margin: 0;
}

&.ck-insert-table-dropdown-grid-box {
padding: 0;
margin: var(--ck-insert-table-dropdown-box-margin);
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

.ck-dropdown {
padding: 0;
margin: 0;
Expand Down
Loading