Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): make table normalization 9.2-compatible #130

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

deepyaman
Copy link
Collaborator

@deepyaman deepyaman commented Jul 23, 2024

In response to breaking change (adding DropColumns) in ibis-project/ibis#9440

Copy link
Member

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit, take it or leave it.

ibis_ml/core.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.93%. Comparing base (722c448) to head (5eb34fd).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #130   +/-   ##
=======================================
  Coverage   84.92%   84.93%           
=======================================
  Files          26       26           
  Lines        1917     1918    +1     
=======================================
+ Hits         1628     1629    +1     
  Misses        289      289           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deepyaman deepyaman force-pushed the fix/core/normalize-table branch from 73b7458 to 5eb34fd Compare July 23, 2024 21:53
@deepyaman
Copy link
Collaborator Author

deepyaman commented Jul 23, 2024

FYI @jitingxu1 I want to wait to see if ibis-project/ibis#9677 is accepted before merging; if not, I'll remove the comment around reverting to .equals down the road.

@jitingxu1
Copy link
Collaborator

FYI @jitingxu1 I want to wait to see if ibis-project/ibis#9677 is accepted; if not, I'll remove the comment around reverting to .equals down the road.

Thank you so much for your quick fix.

@deepyaman deepyaman merged commit f0263b9 into ibis-project:main Jul 24, 2024
4 checks passed
@deepyaman deepyaman deleted the fix/core/normalize-table branch July 24, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants