fix(drop): ignore order for DropColumns equality
#9677
Merged
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
approved these changes
Jul 23, 2024
cpcloud
force-pushed
the
fix/drop/ignore-column-order
branch
from
6e4d337 to
d5a2923
Compare
cpcloud
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Since the ordering doesn't matter for
DropColumns, aVarTuple[str]is probably the wrong data structure for thecolumns_to_dropattribute. This is a bug in the implementation ofDropColumns—we should either change the type (afrozenset[str]would make more sense), or override the comparison so that.equalstreats those as equal.