feat(snowflake): add ArrayRemove implementation

ibis-project · Aug 5, 2023 · 4f9d9f9 · 4f9d9f9
1 parent 465fae1
commit 4f9d9f9
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/ibis/backends/snowflake/registry.py b/ibis/backends/snowflake/registry.py
@@ -399,6 +399,7 @@ def _map_get(t, op):
             lambda left, right: sa.func.array_distinct(sa.func.array_cat(left, right)),
             2,
         ),
+        ops.ArrayRemove: fixed_arity(sa.func.array_remove, 2),
         ops.StringSplit: fixed_arity(sa.func.split, 2),
         # snowflake typeof only accepts VARIANT, so we cast
         ops.TypeOf: unary(lambda arg: sa.func.typeof(sa.func.to_variant(arg))),
@@ -470,7 +471,6 @@ def _map_get(t, op):
     ops.CumulativeOp,
     ops.NTile,
     # ibis.expr.operations.array
-    ops.ArrayRemove,
     ops.ArrayRepeat,
     # ibis.expr.operations.reductions
     ops.MultiQuantile,

diff --git a/ibis/backends/tests/test_array.py b/ibis/backends/tests/test_array.py
@@ -604,7 +604,6 @@ def test_array_position(backend, con):
         "pandas",
         "polars",
         "postgres",
-        "snowflake",
     ],
     raises=com.OperationNotDefinedError,
 )