feat(snowflake): implement StringSplit

ibis-project · Jan 18, 2023 · e6acc09 · e6acc09
1 parent c425f68
commit e6acc09
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 11 deletions.
diff --git a/ibis/backends/snowflake/registry.py b/ibis/backends/snowflake/registry.py
@@ -215,6 +215,7 @@ def _map(_, op):
         ),
         ops.ArraySlice: _array_slice,
         ops.ArrayCollect: reduction(sa.func.array_agg),
+        ops.StringSplit: fixed_arity(sa.func.split, 2),
         ops.Map: _map,
     }
 )
@@ -243,7 +244,6 @@ def _map(_, op):
     ops.RegexExtract,
     ops.RegexReplace,
     ops.RegexSearch,
-    ops.StringSplit,
     # ibis.expr.operations.structs
     ops.StructField,
     # ibis.expr.operations.temporal

diff --git a/ibis/backends/tests/test_param.py b/ibis/backends/tests/test_param.py
@@ -143,7 +143,7 @@ def test_scalar_param(alltypes, df, value, dtype, col):
     ],
 )
 @pytest.mark.notimpl(
-    ["mysql", "polars", "dask", "datafusion", "sqlite", "snowflake", "impala", "mssql"]
+    ["mysql", "polars", "dask", "datafusion", "sqlite", "impala", "mssql"]
 )
 def test_scalar_param_date(backend, alltypes, value, dtype):
     param = ibis.param(dtype)

diff --git a/ibis/backends/tests/test_string.py b/ibis/backends/tests/test_string.py
@@ -339,15 +339,7 @@ def test_string_col_is_unicode(alltypes, df):
             lambda t: t.date_string_col.str.split('/'),
             id='split',
             marks=pytest.mark.notimpl(
-                [
-                    "dask",
-                    "datafusion",
-                    "impala",
-                    "mysql",
-                    "sqlite",
-                    "snowflake",
-                    "mssql",
-                ]
+                ["dask", "datafusion", "impala", "mysql", "sqlite", "mssql"]
             ),
         ),
         param(