You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All backends seem to provide list_tables, but with a variety of signatures.
I propose to standardize all them to the same, so things are simpler and clearer, and code can be reused from one backend to another easier. My preferred signature would be:
deflist_tables(self, like: str=None) ->List[str]:
We can add a FutureWarning for Ibis 2.0, if other parameters are used. I'll add **kwargs, and if not empty, a warning will be shown, and in 3.0 we can remove 3.0. I'll also deprecate list_tables in Database, in favor of the Client one.
I think it's a good idea to deprecate Database.list_tables and keep only Client.list_tables. It seems like backends want the ability to expose their own filtering mechanisms, and like may be either unsupported or insufficient; so we should add an abstract method which takes **kwargs instead of any guaranteed arguments. Then we can leave the existing Client.list_tables() as they are.
Fixesibis-project#2877 -- most of the differing signatures were removed in earlier
refactors -- this is the only one left (except for a mock fixture in the
test suite)
Fixes#2877 -- most of the differing signatures were removed in earlier
refactors -- this is the only one left (except for a mock fixture in the
test suite)
All backends seem to provide
list_tables
, but with a variety of signatures.I propose to standardize all them to the same, so things are simpler and clearer, and code can be reused from one backend to another easier. My preferred signature would be:
We can add a
FutureWarning
for Ibis 2.0, if other parameters are used. I'll add**kwargs
, and if not empty, a warning will be shown, and in 3.0 we can remove 3.0. I'll also deprecatelist_tables
inDatabase
, in favor of theClient
one.Let me know if anyone disagrees, or any comment.
The list of current signatures is next:
The text was updated successfully, but these errors were encountered: