Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: standardize list_tables signature everywhere #4793

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

gforsyth
Copy link
Member

@gforsyth gforsyth commented Nov 7, 2022

Fixes #2877 -- most of the differing signatures were removed in earlier refactors -- this is the only one left (except for a mock fixture in the test suite)

Fixes ibis-project#2877 -- most of the differing signatures were removed in earlier
refactors -- this is the only one left (except for a mock fixture in the
test suite)
Copy link
Member

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

Test Results

       39 files         39 suites   1h 35m 58s ⏱️
10 844 tests   8 422 ✔️ 2 422 💤 0
39 806 runs  30 480 ✔️ 9 326 💤 0

Results for commit be0651a.

♻️ This comment has been updated with latest results.

@jcrist jcrist merged commit abafe1b into ibis-project:master Nov 8, 2022
@gforsyth gforsyth deleted the gil/unify_list_tables branch November 8, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: standardize list_tables signature
2 participants