Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: ibis.array([ibis.literal(1), ibis.literal(2)]) returns ArrayColumn, not ArrayScalar #8022

Closed
1 task done
NickCrews opened this issue Jan 18, 2024 · 2 comments · Fixed by #8049
Closed
1 task done

bug: ibis.array([ibis.literal(1), ibis.literal(2)]) returns ArrayColumn, not ArrayScalar #8022

NickCrews opened this issue Jan 18, 2024 · 2 comments · Fixed by #8049
Assignees
@cpcloud
Labels
bug Incorrect behavior inside of ibis datatypes Issues relating to ibis's datatypes (under `ibis.expr.datatypes`) ux User experience related issues
Milestone
8.0

Comments

@NickCrews
Copy link
Contributor

What happened?

as it says. PR incoming.

What version of ibis are you using?

main

What backend(s) are you using, if any?

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@NickCrews NickCrews added the bug Incorrect behavior inside of ibis label Jan 18, 2024
NickCrews added a commit to NickCrews/ibis that referenced this issue Jan 18, 2024
@NickCrews
test: add xfail test for ibis.array(Scalar) -> ArrayColumn
a53d244 
An xfail test for ibis-project#8022
@NickCrews NickCrews mentioned this issue Jan 18, 2024
Closed
NickCrews added a commit to NickCrews/ibis that referenced this issue Jan 19, 2024
@NickCrews
test: add xfail test for ibis.array(Scalar) -> ArrayColumn
5fa5125 
An xfail test for ibis-project#8022
@cpcloud cpcloud self-assigned this Jan 20, 2024
@cpcloud cpcloud added ux User experience related issues datatypes Issues relating to ibis's datatypes (under `ibis.expr.datatypes`) labels Jan 20, 2024
@cpcloud cpcloud added this to the 8.0 milestone Jan 20, 2024
@cpcloud cpcloud mentioned this issue Jan 20, 2024
Merged
kszucs pushed a commit that referenced this issue Jan 22, 2024
@cpcloud @NickCrews
fix(datatypes): ensure that array construction supports literals and …
899dce1 
…infers their shape from its inputs (#8049)

We were previously returning `ArrayColumn` from `ibis.array` when any
inputs were expressions regardless of their shape. This PR renames
`ArrayColumn` -> `Array` and uses the input arguments shapes to
determine the output array shape.

Fixes #8022.

---------

Co-authored-by: Nick Crews <nicholas.b.crews@gmail.com>
@github-project-automation github-project-automation bot moved this from backlog to done in Ibis planning and roadmap Jan 22, 2024
@NickCrews
Copy link
Contributor Author

Yay thank you @cpcloud and @kszucs !

@kszucs
Copy link
Member

kszucs commented Jan 23, 2024

Thanks @NickCrews for both the report and the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpcloud cpcloud

Labels
bug Incorrect behavior inside of ibis datatypes Issues relating to ibis's datatypes (under `ibis.expr.datatypes`) ux User experience related issues
Projects
Ibis planning and roadmap
Archived in project
Milestone
8.0
3 participants
@cpcloud @kszucs @NickCrews