Tweak ibis.array() docstring, improve test, add xfail test #8023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACTION NEEDED Ibis follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
pd.concat and dd.concat can only handle array-likes. If we are given a scalar, we need to convert it to a Series.
NickCrews
force-pushed
the
array_scalar_from_scalar
branch
from
a53d244 to
5fa5125
Compare
|
I think the abstraction is a bit off for construction of array literals. We shouldn't be constructing an |
|
@NickCrews If you don't mind I'm going to cherry pick the first two commits here and apply them to #8049! |
|
you're right, using .shape makes way more sense. that new PR looks like a better move! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds an xfail test for #8022
I discovered that actually fixing the problem wasn't trivial, as I wasn't sure about the ibis internals and how to create an ArrayScalar object correctly. But still I think this is an improvement.
Not totally in love with how I patched ibis.options.repr.interactive.max_length, open to suggestions.
Also discovered that pandas and dask can't handle mixed scalars and columns, so I fixed that.