Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: test examples #10098

Merged
merged 5 commits into from
Sep 11, 2024
Merged

ci: test examples #10098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0f20cce
ci: test examples
cpcloud Sep 11, 2024
ede8e5d
chore: no need for examples in simple bigquery tests
cpcloud Sep 11, 2024
539f193
chore: add examples extra to clouds
cpcloud Sep 11, 2024
b98a4b1
fix(datafusion): import pyarrow at the top level
cpcloud Sep 11, 2024
a92afac
test(datafusion): import pyarrow import into the test
cpcloud Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ibis-backends-cloud.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ jobs:
run: poetry add snowflake-snowpark-python --python="==${{ steps.install_python.outputs.python-version }}"

- name: install ibis
run: poetry install --without dev --without docs --extras "${{ join(matrix.backend.extras, ' ') }}"
run: poetry install --without dev --without docs --extras "${{ join(matrix.backend.extras, ' ') }} examples"

- uses: extractions/setup-just@v2
env:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ibis-backends.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ jobs:
run: pip install 'poetry==1.8.3'

- name: install ibis
run: poetry install --without dev --without docs --extras "${{ join(matrix.backend.extras, ' ') }}"
run: poetry install --without dev --without docs --extras "${{ join(matrix.backend.extras, ' ') }} examples"

- name: install deps for broken avro-python setup
if: matrix.backend.name == 'flink'
Expand Down Expand Up @@ -663,7 +663,7 @@ jobs:
run: poetry lock --no-update

- name: install ibis
run: poetry install --without dev --without docs --extras "${{ join(matrix.backend.extras, ' ') }}"
run: poetry install --without dev --without docs --extras "${{ join(matrix.backend.extras, ' ') }} examples"

- name: run tests
run: just ci-check -m ${{ matrix.backend.name }} --numprocesses auto --dist=loadgroup
Expand Down Expand Up @@ -749,7 +749,7 @@ jobs:
run: poetry lock --no-update

- name: install ibis
run: poetry install --without dev --without docs --extras pyspark
run: poetry install --without dev --without docs --extras "pyspark examples"

- name: install delta-spark
if: matrix.pyspark-version == '3.5'
Expand Down
3 changes: 2 additions & 1 deletion ibis/backends/datafusion/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

import datafusion as df
import pyarrow as pa
import pyarrow.dataset as ds
import pyarrow_hotfix # noqa: F401
import sqlglot as sg
import sqlglot.expressions as sge
Expand Down Expand Up @@ -372,7 +373,7 @@ def _register(
self.con.deregister_table(table_name)
self.con.register_record_batches(table_name, [[source]])
return self.table(table_name)
elif isinstance(source, pa.dataset.Dataset):
elif isinstance(source, ds.Dataset):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be unrelated to including examples in the tests suit, just making sure you are ok with that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are definitely related. They aren't hit unless the examples are run.

self.con.deregister_table(table_name)
self.con.register_dataset(table_name, source)
return self.table(table_name)
Expand Down
3 changes: 2 additions & 1 deletion ibis/backends/datafusion/tests/test_register.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import pandas as pd
import pyarrow as pa
import pyarrow.dataset as ds
import pytest

import ibis
Expand Down Expand Up @@ -45,6 +44,8 @@ def test_register_batches(conn):


def test_register_dataset(conn):
import pyarrow.dataset as ds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same that the comment above. If we are good with these nits getting in here, all good.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely related, for the same reason.


tab = pa.table({"x": [1, 2, 3]})
dataset = ds.InMemoryDataset(tab)
with pytest.warns(FutureWarning, match="v9.1"):
Expand Down