ci: test examples #10098
Merged
ci: test examples #10098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
bug
cpcloud
force-pushed
the
actually-test-examples
branch
from
7f06ad2
to
a92afac
Compare
ncclementi
approved these changes
Sep 11, 2024
| @@ -372,7 +373,7 @@ def _register( | |||
| self.con.deregister_table(table_name) | |||
| self.con.register_record_batches(table_name, [[source]]) | |||
| return self.table(table_name) | |||
| elif isinstance(source, pa.dataset.Dataset): | |||
| elif isinstance(source, ds.Dataset): | |||
There was a problem hiding this comment.
This seems to be unrelated to including examples in the tests suit, just making sure you are ok with that.
There was a problem hiding this comment.
These are definitely related. They aren't hit unless the examples are run.
| @@ -45,6 +44,8 @@ def test_register_batches(conn): | |||
|
|
|||
|
|
|||
| def test_register_dataset(conn): | |||
| import pyarrow.dataset as ds | |||
There was a problem hiding this comment.
same that the comment above. If we are good with these nits getting in here, all good.
There was a problem hiding this comment.
Definitely related, for the same reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not testing examples in CI because we did not install the
examplesextra. Now we are.