Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: fix(datafusion): raise when attempting to create temp table (#10072) #10099

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

gforsyth
Copy link
Member

@gforsyth gforsyth commented Sep 11, 2024

This reverts commit 1cf5439.

The Datafusion temporary table aren't temporary tables in the sense of where they are registered in the information_schema, but they are definitely ephemeral. Also, removing this broke a bunch of stuff that our CI didn't catch (yikes), so reverting while we sort that out.

@gforsyth gforsyth changed the title Revert "fix(datafusion): raise when attempting to create temp table (#10072)" revert: fix(datafusion): raise when attempting to create temp table (#10072) Sep 11, 2024
@cpcloud
Copy link
Member

cpcloud commented Sep 11, 2024

Cherry picking this onto my branch from #10098 allows datafusion to pass.

❯ pytest -m datafusion ibis/backends/tests/test_examples.py -x
...
ibis/backends/tests/test_examples.py ....                                                                [100%]

@cpcloud cpcloud enabled auto-merge (squash) September 11, 2024 18:54
@cpcloud cpcloud merged commit d48a575 into ibis-project:main Sep 11, 2024
83 checks passed
@cpcloud cpcloud added this to the 9.5 milestone Sep 11, 2024
@gforsyth gforsyth deleted the revert_datafusion_temp branch September 11, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants