Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(impala): A delimited table explicitly declare stored as textfile #4271

Merged
merged 1 commit into from
Jul 23, 2022
Merged

fix(impala): A delimited table explicitly declare stored as textfile #4271

merged 1 commit into from
Jul 23, 2022

Conversation

yi-you
Copy link
Contributor

@yi-you yi-you commented Jul 23, 2022

fixes #4260

@github-actions
Copy link
Contributor

github-actions bot commented Jul 23, 2022 •
edited
Loading

Test Results

       35 files         35 suites   1h 10m 11s ⏱️
  8 799 tests   7 042 ✔️ 1 757 💤 0 ❌
32 226 runs  25 543 ✔️ 6 683 💤 0 ❌

Results for commit 7bac040.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jul 23, 2022 •
edited
Loading

Codecov Report

Merging #4271 (9fb150c) into master (f5f7f90) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4271      +/-   ##
==========================================
- Coverage   92.57%   92.57%   -0.01%     
==========================================
  Files         179      179              
  Lines       20185    20186       +1     
  Branches     2887     2887              
==========================================
  Hits        18687    18687              
  Misses       1134     1134              
- Partials      364      365       +1
Impacted Files Coverage Δ
ibis/backends/impala/ddl.py 97.54% <100.00%> (+0.01%) ⬆️
ibis/backends/impala/__init__.py 85.92% <0.00%> (-0.22%) ⬇️

@cpcloud cpcloud added this to the 3.1 milestone Jul 23, 2022
@cpcloud cpcloud added bug Incorrect behavior inside of ibis impala The Apache Impala backend labels Jul 23, 2022
@cpcloud
Copy link
Member

cpcloud commented Jul 23, 2022

Thanks!

@cpcloud cpcloud merged commit 04086a4 into ibis-project:master Jul 23, 2022
@cpcloud cpcloud added the ddl Issues related to creating or altering data definitions label Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior inside of ibis ddl Issues related to creating or altering data definitions impala The Apache Impala backend
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

bug(impala) A delimited table should be explicitly stored as textfile
2 participants
@yi-you @cpcloud