-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Add Table.sample
#7377
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eral SQL backends
cpcloud
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments, nothing blocking.
This is great 🎉, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new method
Table.sample
for selecting a random sample of rows from a table.The method takes the following arguments:
fraction
: a float between 0 and 1 representing the fraction of rows to selectmethod
: either"row"
or"block"
(defaults to"row"
) describing how to perform the sample. Blockwise sampling my be more efficient for some backends at the potential cost of correctnessseed
: a random seed to use for repeatabilityWhen possible this is compiled as a
TABLESAMPLE
clause, falling back tot.filter(ibis.random() <= fraction)
if that's not available. However, there are a few backends where we could use a tablesample but currently don't:postgres
andimpala
: these backends supportTABLESAMPLE
, but only for physical tables (not subqueries, views, ...). For now we support these backends via rewriting tot.filter(random() <= fraction)
. I think we should be able to support compilingTable.sample
to optionally use aTABLESAMPLE
when possible for these backends, but that's not implemented here.bigquery
: same, but also only supports blockwise sampling. I've left this backend unimplemented for now.snowflake
: should be supportable, just didn't in this PR since I can't currently test against snowflake.clickhouse
andoracle
: these backends have a sampling syntax, but it only works on physical tables with certain metadata (indices, sampling setup, ...). I don't think we can support their sampling syntax without losing the ability to sample arbitrary table expressions.Closes #7139.