chore(bigquery): regenerate sql #7384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
tests
jcrist
approved these changes
Oct 17, 2023
|
Oop, sorry, forgot to check biquery on that PR (I haven't yet setup local testing on bigquery). FWIW the logic here now matches that done in the sqlalchemy backend and I think should be correct. it's encouraging that this was the only breakage. |
|
No worries! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerate some failing bigquery test snapshots. I think this is due to these lines from #7377. Previously we unconditionally produced an alias in the string compiler, in that PR we only produce one if the the retrieved reference does not match the alias