Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(mysql): port to sqlglot #7926

Merged
merged 4 commits into from
Jan 6, 2024
Merged

refactor(mysql): port to sqlglot #7926

merged 4 commits into from
Jan 6, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jan 6, 2024

Port the MySQL backend to sqlglot. Depends on #7877.

@cpcloud cpcloud added refactor Issues or PRs related to refactoring the codebase mysql The MySQL backend labels Jan 6, 2024
cpcloud
cpcloud commented Jan 6, 2024
View reviewed changes
ibis/backends/mssql/tests/test_client.py
+ [
param("GEOMETRY", dt.geometry, marks=[skipif_no_geospatial_deps]),
param("GEOGRAPHY", dt.geography, marks=[skipif_no_geospatial_deps]),
]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll bring this back in the MS SQL port

cpcloud
cpcloud commented Jan 6, 2024
View reviewed changes
ibis/backends/base/sqlglot/__init__.py Outdated Show resolved Hide resolved
ibis/backends/tests/test_numeric.py Show resolved Hide resolved
ibis/expr/rewrites.py Outdated Show resolved Hide resolved
@cpcloud cpcloud mentioned this pull request Jan 6, 2024
Closed
21 tasks
@cpcloud cpcloud force-pushed the tes-mysql branch 3 times, most recently from 1af0dee to f039f47 Compare January 6, 2024 11:06
@cpcloud
Copy link
Member Author

cpcloud commented Jan 6, 2024

I'll remove the geospatial function mapping since we're not testing that for mysql yet.

@kszucs kszucs mentioned this pull request Jan 6, 2024
Open
kszucs
kszucs reviewed Jan 6, 2024
View reviewed changes
ibis/formats/pandas.py Outdated Show resolved Hide resolved
@kszucs kszucs enabled auto-merge (squash) January 6, 2024 12:29
@cpcloud
Copy link
Member Author

cpcloud commented Jan 6, 2024

Snowflake tests look good:

…/ibis on  tes-mysql is 📦 v7.2.0 via 🐍 v3.10.13 via ❄️  impure (ibis-3.10.13-env)
❯ pytest -m snowflake --snapshot-update -n 8 --dist loadgroup -q
bringing up nodes...
...x..x.........................x..x.x.x....xxx......x.x....x...x....x.x.....xxxxx...xx..xx...x.x...x.x.xx............x..x....x.x..xx.xx...x.x.....x.x.......xx..x...xx....x.x....x......x.xx. [ 13%]
.x......x..x.......x....x......x....xx....x.x...........x.....xxxxx........x........x.....x..............................................x..x......xxx....xx.x.....xx..........x.............. [ 26%]
...x......x....x........................x.x.......x..........x.x.....x......................s..x.........xx.x.x...x.xxx....xxxxxxx...........x.x..x........x......x.....x.x.x.........x....... [ 39%]
...........x.........x................x.x.......x........x....x........x..................xxx........................x........x..........x.x.......x....x.....xx...................xx......x.. [ 52%]
...xx.xxx.x..xx....x...x...x......x.....................xx...x....x..x.x.....x...............x.....................xx...............x.......x.............x........x.....x..x...x..........x.. [ 65%]
........xx........x..............x.....x..........xxx......x.x...........x.............x..........x...........x..................................x.............................x.............x [ 78%]
..x.....x...xxxx.x...x.......x....x..............x.....x.............................................................................s........................................................ [ 91%]
................................................................................................................................s..                                                            [100%]
1260 passed, 3 skipped, 198 xfailed in 138.45s (0:02:18)

@kszucs kszucs merged commit 4a1b52a into ibis-project:the-epic-split Jan 6, 2024
39 checks passed
@cpcloud cpcloud deleted the tes-mysql branch January 6, 2024 12:34
cpcloud added a commit that referenced this pull request Jan 12, 2024
@cpcloud
refactor(mysql): port to sqlglot (#7926)
4f88d1e 
Port the MySQL backend to sqlglot.
cpcloud added a commit that referenced this pull request Jan 13, 2024
@cpcloud
refactor(mysql): port to sqlglot (#7926)
5d1d4b4 
Port the MySQL backend to sqlglot.
cpcloud added a commit that referenced this pull request Jan 17, 2024
@cpcloud
refactor(mysql): port to sqlglot (#7926)
4d38f16 
Port the MySQL backend to sqlglot.
@kszucs kszucs mentioned this pull request Jan 18, 2024
Merged
gforsyth pushed a commit to gforsyth/ibis that referenced this pull request Jan 18, 2024
@cpcloud @gforsyth
refactor(mysql): port to sqlglot (ibis-project#7926)
cf14389 
Port the MySQL backend to sqlglot.
@gforsyth gforsyth mentioned this pull request Jan 23, 2024
Merged
@kszucs kszucs mentioned this pull request Feb 1, 2024
Closed
kszucs pushed a commit to kszucs/ibis that referenced this pull request Feb 1, 2024
@cpcloud @kszucs
refactor(mysql): port to sqlglot (ibis-project#7926)
95fd31b 
Port the MySQL backend to sqlglot.
kszucs pushed a commit to kszucs/ibis that referenced this pull request Feb 1, 2024
@cpcloud @kszucs
refactor(mysql): port to sqlglot (ibis-project#7926)
2aa3f05 
Port the MySQL backend to sqlglot.
kszucs pushed a commit to kszucs/ibis that referenced this pull request Feb 1, 2024
@cpcloud @kszucs
refactor(mysql): port to sqlglot (ibis-project#7926)
7ca195f 
Port the MySQL backend to sqlglot.
kszucs pushed a commit to kszucs/ibis that referenced this pull request Feb 2, 2024
@cpcloud @kszucs
refactor(mysql): port to sqlglot (ibis-project#7926)
2888a88 
Port the MySQL backend to sqlglot.
kszucs pushed a commit to kszucs/ibis that referenced this pull request Feb 2, 2024
@cpcloud @kszucs
refactor(mysql): port to sqlglot (ibis-project#7926)
824dc94 
Port the MySQL backend to sqlglot.
kszucs pushed a commit to kszucs/ibis that referenced this pull request Feb 2, 2024
@cpcloud @kszucs
refactor(mysql): port to sqlglot (ibis-project#7926)
abdebfd 
Port the MySQL backend to sqlglot.
cpcloud added a commit to cpcloud/ibis that referenced this pull request Feb 4, 2024
@cpcloud
refactor(mysql): port to sqlglot (ibis-project#7926)
527fa5e 
Port the MySQL backend to sqlglot.
cpcloud added a commit to cpcloud/ibis that referenced this pull request Feb 5, 2024
@cpcloud
refactor(mysql): port to sqlglot (ibis-project#7926)
eb8bf32 
Port the MySQL backend to sqlglot.
kszucs pushed a commit that referenced this pull request Feb 5, 2024
@cpcloud @kszucs
refactor(mysql): port to sqlglot (#7926)
97a1e2e 
Port the MySQL backend to sqlglot.
kszucs pushed a commit that referenced this pull request Feb 6, 2024
@cpcloud @kszucs
refactor(mysql): port to sqlglot (#7926)
eaf6540 
Port the MySQL backend to sqlglot.
kszucs pushed a commit that referenced this pull request Feb 6, 2024
@cpcloud @kszucs
refactor(mysql): port to sqlglot (#7926)
20a8a0d 
Port the MySQL backend to sqlglot.
cpcloud added a commit to cpcloud/ibis that referenced this pull request Feb 12, 2024
@cpcloud
refactor(mysql): port to sqlglot (ibis-project#7926)
f2d3e90 
Port the MySQL backend to sqlglot.
cpcloud added a commit that referenced this pull request Feb 12, 2024
@cpcloud
refactor(mysql): port to sqlglot (#7926)
3f97c98 
Port the MySQL backend to sqlglot.
cpcloud added a commit to cpcloud/ibis that referenced this pull request Feb 12, 2024
@cpcloud
refactor(mysql): port to sqlglot (ibis-project#7926)
3a4e36d 
Port the MySQL backend to sqlglot.
cpcloud added a commit that referenced this pull request Feb 12, 2024
@cpcloud
refactor(mysql): port to sqlglot (#7926)
fba97a8 
Port the MySQL backend to sqlglot.
kszucs pushed a commit that referenced this pull request Feb 12, 2024
@cpcloud @kszucs
refactor(mysql): port to sqlglot (#7926)
cba2f98 
Port the MySQL backend to sqlglot.
ncclementi pushed a commit to ncclementi/ibis that referenced this pull request Feb 21, 2024
@cpcloud @ncclementi
refactor(mysql): port to sqlglot (ibis-project#7926)
0a3d230 
Port the MySQL backend to sqlglot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kszucs kszucs kszucs approved these changes

Assignees
No one assigned
Labels
mysql The MySQL backend refactor Issues or PRs related to refactoring the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpcloud @kszucs