fix(mutate/select): ensure that unsplatted dictionaries work in mutateandselect APIs
#8014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
bug
|
ACTION NEEDED Ibis follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
cpcloud
changed the title
muta… …teandselect APIs
cpcloud
changed the title
muta… …teandselect APIsmutateandselect APIs
cpcloud
force-pushed
the
unnest-range
branch
2 times, most recently
from
6cb933f
to
faf7cb2
Compare
jcrist
reviewed
Jan 18, 2024
|
|
||
| for expr in exprs: | ||
| if isinstance(expr, Selector): | ||
| new_exprs.extend(expr.expand(self)) |
There was a problem hiding this comment.
_ensure_expr handles selector expansion, I think this case could be dropped and handled by the not-mapping branch below?
There was a problem hiding this comment.
Unfortunately it won't work because expr.expand(self) returns a list and so map(self._ensure_expr, ...) returns an iterable of lists and that isn't supported by Projector.
jcrist
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not handling unsplatted dicts in mutate/select, this PR fixes that. Fixes #8013.