Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backends): make string concat-with-null behavior consistent across backends #8305

Merged
merged 8 commits into from
Feb 12, 2024
Merged

fix(backends): make string concat-with-null behavior consistent across backends #8305

merged 8 commits into from
Feb 12, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Feb 11, 2024

Fixes #8302.

@cpcloud cpcloud added this to the 9.0 milestone Feb 11, 2024
@cpcloud cpcloud added bug Incorrect behavior inside of ibis postgres The PostgreSQL backend duckdb The DuckDB backend sql Backends that generate SQL labels Feb 11, 2024
@cpcloud cpcloud mentioned this pull request Feb 11, 2024
Closed
@cpcloud
Copy link
Member Author

cpcloud commented Feb 11, 2024

Turns out this is just wildly inconsistent across databases, what else is new 😄

@cpcloud cpcloud changed the title fix(duckdb/postgres): make string concat-with-null behavior consistent across backends fix(backends): make string concat-with-null behavior consistent across backends Feb 11, 2024
@cpcloud cpcloud added datafusion The Apache DataFusion backend oracle The Oracle backend exasol Issues related to the exasol backend mssql The Microsoft SQL Server backend and removed sql Backends that generate SQL labels Feb 11, 2024
@kszucs kszucs merged commit f76b21e into ibis-project:the-epic-split Feb 12, 2024
69 checks passed
@cpcloud cpcloud deleted the concat-with-null branch February 12, 2024 10:38
@cpcloud cpcloud mentioned this pull request Feb 12, 2024
Closed
1 task
cpcloud added a commit to cpcloud/ibis that referenced this pull request Feb 12, 2024
@cpcloud
fix(backends): make string concat-with-null behavior consistent acros…
cc2a395 
…s backends (ibis-project#8305)

Fixes ibis-project#8302.
cpcloud added a commit that referenced this pull request Feb 12, 2024
@cpcloud
fix(backends): make string concat-with-null behavior consistent acros…
2255ac6 
…s backends (#8305)

Fixes #8302.
cpcloud added a commit to cpcloud/ibis that referenced this pull request Feb 12, 2024
@cpcloud
fix(backends): make string concat-with-null behavior consistent acros…
37eba80 
…s backends (ibis-project#8305)

Fixes ibis-project#8302.
cpcloud added a commit that referenced this pull request Feb 12, 2024
@cpcloud
fix(backends): make string concat-with-null behavior consistent acros…
4e3cd6a 
…s backends (#8305)

Fixes #8302.
kszucs pushed a commit that referenced this pull request Feb 12, 2024
@cpcloud @kszucs
fix(backends): make string concat-with-null behavior consistent acros…
2d97b8e 
…s backends (#8305)

Fixes #8302.
ncclementi pushed a commit to ncclementi/ibis that referenced this pull request Feb 21, 2024
@cpcloud @ncclementi
fix(backends): make string concat-with-null behavior consistent acros…
7ec28d1 
…s backends (ibis-project#8305)

Fixes ibis-project#8302.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kszucs kszucs kszucs approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior inside of ibis datafusion The Apache DataFusion backend duckdb The DuckDB backend exasol Issues related to the exasol backend mssql The Microsoft SQL Server backend oracle The Oracle backend postgres The PostgreSQL backend
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cpcloud @kszucs