Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(case): fix dshape, error on noncomparable and empty cases #9559

Merged
merged 2 commits into from
Jul 24, 2024
Merged

fix(case): fix dshape, error on noncomparable and empty cases #9559

merged 2 commits into from
Jul 24, 2024

Commits on Jul 24, 2024

  1. fix(case): fix dshape, error on noncomparable and empty cases 

    This is pinning down the expected behavior for cases before tackling
the case() to cases() switch in
ibis-project#9096
so that PR can be simpler

I move the validation for comparable-ness down into the operation so that
the logic is consolidated to one place.
in ibis-project#9096 there might be multiple places that construct an ops.SimpleCase, and we don't want
to have to implement the validation in all
calling locations.

We could consider relaxing the limitation for non-empty cases later, but for now lets be strict.

I already fixed the shape of ops.SearchedCase in ibis-project#9334,
but it looks like in that PR I forgot to also fix ops.SimpleCase, so I do that fix here.
    @NickCrews @cpcloud
    NickCrews authored and cpcloud committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    87329a0 View commit details
    Browse the repository at this point in the history

  2. test: remove bogus test case

    @cpcloud
    cpcloud committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    7187468 View commit details
    Browse the repository at this point in the history