fix(case): fix dshape, error on noncomparable and empty cases #9559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickCrews
force-pushed
the
tweak-case
branch
2 times, most recently
from
c2b62bb
to
2c5aaec
Compare
NickCrews
commented
Jul 12, 2024
NickCrews
force-pushed
the
tweak-case
branch
2 times, most recently
from
c47b371
to
aee467b
Compare
13 tasks
|
Ok, I think this is pretty close. I'm going to take it over and hopefully merge it. |
cpcloud
reviewed
Jul 23, 2024
cpcloud
approved these changes
Jul 23, 2024
This is pinning down the expected behavior for cases before tackling the case() to cases() switch in ibis-project#9096 so that PR can be simpler I move the validation for comparable-ness down into the operation so that the logic is consolidated to one place. in ibis-project#9096 there might be multiple places that construct an ops.SimpleCase, and we don't want to have to implement the validation in all calling locations. We could consider relaxing the limitation for non-empty cases later, but for now lets be strict. I already fixed the shape of ops.SearchedCase in ibis-project#9334, but it looks like in that PR I forgot to also fix ops.SimpleCase, so I do that fix here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pinning down the expected behavior for cases before tackling the case() to cases() switch in #9096 so that PR can be simpler