fix: don't crash on iOS because of an onClickBlock
in react-native 0.73.2
#31
+55
−40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading
react-native
to0.73.2
for our project we faced this crash which did not happen inreact-native
version0.72.5
ref -> status-im/status-mobile#18563 (comment)
This PR fixes that crash by modifying
RNHoleViewImpl
interface to acceptsetOnClick
This is a very basic implementation just so that we avoid the crash without having to change the way we use
react-native-hole-view
in our codebase.If you would like this to be done some other way I would be happy to incorporate any feedback you have.
Looking forward to your thoughts on this @stephenkopylov