Upgrade react native to 0.73.5
#18563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
siddarthkay
commented
Jan 18, 2024
siddarthkay
commented
Jan 18, 2024
siddarthkay
commented
Jan 18, 2024
siddarthkay
commented
Jan 18, 2024
Jenkins BuildsClick to see older builds (252)
|
flexsurfer
approved these changes
Jan 18, 2024
58% of end-end tests have passedFailed tests (16)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (4)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Passed tests (28)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
|
88% of end-end tests have passedFailed tests (3)Click to expandClass TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (3)Click to expandClass TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (42)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestDeepLinksOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
|
90% of end-end tests have passedFailed tests (2)Click to expandClass TestActivityMultipleDevicePRTwo:
Expected to fail tests (3)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Passed tests (43)Click to expandClass TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestDeepLinksOneDevice:
|
siddarthkay
force-pushed
the
upgrade-react-native-to-0_73
branch
from
fe1fcd0
to
0c25850
Compare
|
Hey @siddarthkay thank you for PR. Take a look please a found issue: ISSUE 1 [IOS] White screen appears on [IOS] after reopening the app post-onboardingSteps:
Actual result:White screen is shown whitescreen.mp4Expected result:The login screen is shown after app reopening logs:Device:
|
|
Thanks for testing @VolodLytvynenko : I'll take a look at the issue |
|
Hmm I was able to reproduce this issue after logging out, will investigate further. |
siddarthkay
force-pushed
the
upgrade-react-native-to-0_73
branch
from
0c25850
to
c857656
Compare
|
The issue is with 
|
|
I tried to patch this library and it works, I'll send a PR to the lib and see what the author thinks. diff --git a/node_modules/react-native-hole-view/ios/RNHoleView/RNHoleViewImpl.h b/node_modules/
react-native-hole-view/ios/RNHoleView/RNHoleViewImpl.h
index 354512d..4907694 100644
--- a/node_modules/react-native-hole-view/ios/RNHoleView/RNHoleViewImpl.h
+++ b/node_modules/react-native-hole-view/ios/RNHoleView/RNHoleViewImpl.h
@@ -43,4 +43,6 @@ typedef void(^AnimationFinishedCallback)();
@property (nonatomic, copy) AnimationFinishedCallback onAnimationFinishedFabric;
+- (void)setOnClick:(void (^)(void))onClickBlock;
+
@end
diff --git a/node_modules/react-native-hole-view/ios/RNHoleView/RNHoleViewImpl.m b/node_modules/
react-native-hole-view/ios/RNHoleView/RNHoleViewImpl.m
index da5ae14..ee91a93 100644
--- a/node_modules/react-native-hole-view/ios/RNHoleView/RNHoleViewImpl.m
+++ b/node_modules/react-native-hole-view/ios/RNHoleView/RNHoleViewImpl.m
@@ -50,6 +50,8 @@ @interface RNHoleViewImpl()<CAAnimationDelegate>
@property (nonatomic) dispatch_source_t holesTimer;
+@property (nonatomic, copy) void (^onClickBlock)(void);
+
@end
@implementation RNHoleViewImpl
@@ -284,4 +286,15 @@ -(void)animationDidStop:(CAAnimation *)anim finished:(BOOL)finished{
}
}
+- (void)setOnClick:(void (^)(void))onClickBlock {
+ _onClickBlock = onClickBlock;
+ [self addGestureRecognizer:[[UITapGestureRecognizer alloc] initWithTarget:self action:@selector(handleTap)]];
+}
+
+- (void)handleTap {
+ if (self.onClickBlock) {
+ self.onClickBlock();
+ }
+}
+
@end |
83% of end-end tests have passedFailed tests (7)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (40)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
|
|
@VolodLytvynenko : could you pls check if push notifications work now? |
siddarthkay
force-pushed
the
upgrade-react-native-to-0_73
branch
from
b9feb07
to
14b99ff
Compare
yevh-berdnyk
force-pushed
the
upgrade-react-native-to-0_73
branch
from
14b99ff
to
43bd37b
Compare
|
hi @siddarthkay can confirm that issue related to push notifications is fixed, @jo-mut thank you for your work. I will take this PR once more after release branch will be cut |
96% of end-end tests have passedFailed tests (1)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (46)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestActivityMultipleDevicePRTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMergedTwo:
|
92% of end-end tests have passedFailed tests (3)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (44)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestDeepLinksOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePRTwo:
|
siddarthkay
force-pushed
the
upgrade-react-native-to-0_73
branch
3 times, most recently
from
8c73494
to
e7a2bb3
Compare
81% of end-end tests have passedFailed tests (8)Click to expandClass TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (39)Click to expandClass TestDeepLinksOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
|
|
Hi @siddarthkay, this day has finally come for this PR:) Thank you for your patience and for your work. The PR is ready to be merged. |
siddarthkay
force-pushed
the
upgrade-react-native-to-0_73
branch
from
e7a2bb3
to
79b49fa
Compare
fixes #18291 Changes worth mentioning are : - More hacks/patches - Force app to use `Java 17` everywhere to compile `kotlin,java` - `gems` were upgraded after a long time - `aapt2` was bumped to `8.1.1` - `metro` is now at `0.80.4` - `xcbeautify` was bumped to `1.4.0` - `@react-native-community/clipboard` lib was replaced with `@react-native-clipboard/clipboard` - `react-native-dialogs` lib was upgraded to `1.1.2` - `react-native-gesture-handler` lib was upgraded to `2.14.1` - `react-native-navigation` was upgraded to `7.37.2` - Android - iOS
siddarthkay
force-pushed
the
upgrade-react-native-to-0_73
branch
from
79b49fa
to
621ff42
Compare
This was referenced Mar 23, 2024
mmilad75
pushed a commit
that referenced
this pull request
Apr 2, 2024
fixes #18291 ## Summary Changes worth mentioning are : - More hacks/patches - Force app to use `Java 17` everywhere to compile `kotlin,java` - `gems` were upgraded after a long time - `aapt2` was bumped to `8.1.1` - `metro` is now at `0.80.4` - `xcbeautify` was bumped to `1.4.0` - `@react-native-community/clipboard` lib was replaced with `@react-native-clipboard/clipboard` - `react-native-dialogs` lib was upgraded to `1.1.2` - `react-native-gesture-handler` lib was upgraded to `2.14.1` - `react-native-navigation` was upgraded to `7.37.2` ## Platforms - Android - iOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18291
Summary
Changes worth mentioning are :
Java 17everywhere to compilekotlin,javagemswere upgraded after a long timeaapt2was bumped to8.1.1metrois now at0.80.4xcbeautifywas bumped to1.4.0@react-native-community/clipboardlib was replaced with@react-native-clipboard/clipboardreact-native-dialogslib was upgraded to1.1.2react-native-gesture-handlerlib was upgraded to2.14.1react-native-navigationwas upgraded to7.38.3react-native-sharewas upgraded to10.0.2Testing notes
Test everything thoroughly.
Platforms
Known issues / Pains
react-nativeto0.73.4the Android App crashes at runtime because of foreground service #18911make run-iosfails the second time you run it #18869status: ready