Ensure static fields set during signed jar process #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithc-ca
requested changes
Sep 18, 2024
keithc-ca
reviewed
Sep 18, 2024
When loading a signed jar file that is on the classpath, such as the bouncy castle signed JCE jar file, it has been observed that the value of `restrictedJarVerificationProviders` and `jarVerificationProviders` are set to `null`. This causes a NullPointerException during the loading process. This update moves the static declarations of both `restrictedJarVerificationProviders` and `jarVerificationProviders` to be prior to the method call `RestrictedSecurity.checkHashValues()` since this method call needs both of these fields to be initialized to work correctly. Signed-off-by: Jason Katonica <katonica@us.ibm.com>
jasonkatonica
force-pushed
the
katonica/issue524/rsmfailingduetobcsignedjarsnext
branch
from
de10fad
to
a2313ed
Compare
|
Code is now squashed into a single commit. |
|
Jenkins compile alinux jdknext |
keithc-ca
approved these changes
Sep 18, 2024
jasonkatonica
deleted the
katonica/issue524/rsmfailingduetobcsignedjarsnext
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading a signed jar file that is on the classpath, such as the
bouncy castle signed JCE jar file, it has been observed that the value
of
restrictedJarVerificationProvidersandjarVerificationProvidersare set to
null. This causes a NullPointerException during the loadingprocess.
This update moves the static declarations of both
restrictedJarVerificationProvidersandjarVerificationProviderstobe prior to the method call
RestrictedSecurity.checkHashValues()sincethis method call needs both of these fields to be initialized to work
correctly.
Signed-off-by: Jason Katonica katonica@us.ibm.com