Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrollable widget #35

Merged
merged 23 commits into from
Nov 3, 2019
Merged

Scrollable widget #35

merged 23 commits into from
Nov 3, 2019

Conversation

hecrj
Copy link
Member

@hecrj hecrj commented Oct 29, 2019 •
edited
Loading

Fixes #24.

Scrollable section in the tour example

This PR adds a Scrollable widget that can be used to show an infinite amount of content vertically with a scrollbar.

  • Scrolling can be controlled by using the mouse wheel, a touchpad, or dragging the scrollbar directly.
  • The widget event logic only needs to know when the cursor is over the scrollbar, staying renderer-agnostic.
  • A scroll example showcasing a Scrollable has been created.
  • A new Clip primitive is supported by iced_wgpu, which unlocks basic layering capabilities.

Pending work

  • Replace nalgebra dependency in iced_wgpu with something more lightweight.
  • Finish and merge wgpu_glyph scissoring support. Tracking in Debug view #38.
  • Fix text caching. glyph-brush does not allow to perform multiple draw calls without trimming the glyph cache in an easy way. Tracking in Debug view #38.
  • Update tour to contain a scrollable section.

hecrj added 17 commits October 25, 2019 03:47
@hecrj
Draft Scrollable widget (no clipping yet!)
719c073
@hecrj
Expose scrollable offset properly
09bd2c4
@hecrj
Remove Scrollable::justify_content method
63c10b6
@hecrj
Implement clipping for images
0a0aa3e
@hecrj
Remove adapter from iced_wgpu::Renderer
e2668b8
@hecrj
Align items properly inside a Scrollable
82c2aa6
@hecrj
Improve scroll example
e218901
@hecrj
Implement clipping for quads
21eb2f6
@hecrj
Draft text scrolling (no clipping yet!)
35e94f5
@hecrj
Implement text clipping (caching still broken)
2b23e09
@hecrj
Issue draw calls only when necessary
23ebfb7
@hecrj
Draw scrollbar on top of scrollable content
be488ac
@hecrj
Stop leaking impl details in scrollable Renderer
a3c55f7
@hecrj
Complete Scrollable::hash_layout
6602c15
@hecrj
Provide Renderer to Widget::on_event
9dabbf7 
This allows us to implement configurable event processing that adapts to
different rendering strategies.
@hecrj
Implement scrollbar interactions! 🎉
29588f6
@hecrj
Handle touchpad scroll events
bd5d871
@hecrj hecrj added the feature New feature or request label Oct 29, 2019
@hecrj hecrj added this to the 0.1.0 milestone Oct 29, 2019
@hecrj hecrj self-assigned this Oct 29, 2019
@hecrj hecrj mentioned this pull request Oct 31, 2019
Closed
@hecrj hecrj mentioned this pull request Nov 2, 2019
Merged
1 task
@hecrj hecrj mentioned this pull request Nov 3, 2019
Merged
2 tasks
@hecrj hecrj merged commit 0ea911a into master Nov 3, 2019
@hecrj hecrj deleted the feature/scrollables branch November 4, 2019 02:52
@hecrj hecrj mentioned this pull request Nov 5, 2019
Closed
@hecrj hecrj mentioned this pull request Nov 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hecrj hecrj

Labels
feature New feature or request
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

Scrollables / Clippables
1 participant
@hecrj