Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature gates font-kit behind "system_font" feature. #364

Closed

Conversation

azriel91
Copy link
Contributor

Closes #58.

I thought iced wasn't working when nothing was showing up in the examples, and it happened to be #199 / #270 / #351. Should've searched issues earlier =/.

@hecrj
Copy link
Member

hecrj commented May 28, 2020

Hey, thanks!

I have some related work in #354 that will have some conflicts with this. I think it'd be better to wait until that PR lands before tackling this. I will merge it very soon!

@hecrj hecrj added feature New feature or request improvement An internal improvement labels May 28, 2020
@hecrj hecrj added this to the 0.2.0 milestone May 28, 2020
@azriel91
Copy link
Contributor Author

Closing as this is already feature gated in master ✌️

@azriel91 azriel91 closed this May 30, 2020
@azriel91 azriel91 deleted the improvement/58/feature-gate-font-kit branch May 30, 2020 06:52
@hecrj
Copy link
Member

hecrj commented May 30, 2020

It's not completely feature-gated yet!

iced_wgpu and iced_glow both always enable the font-source feature of iced_graphics. We should probably add a feature flag default-system-font to both like you did in this PR and enable it by default.

@azriel91
Copy link
Contributor Author

oh! shall quickly do that now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request improvement An internal improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use something other than font-kit and/or put it behind feature gate
2 participants