Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/58/feature gate font kit #370

Merged
merged 2 commits into from
Jun 1, 2020

Conversation

azriel91
Copy link
Contributor

@azriel91 azriel91 commented May 30, 2020

Closes #58.

I thought iced wasn't working when nothing was showing up in the examples, and it happened to be #199 / #270 / #351. Should've searched issues earlier.

Successor to #364 -- couldn't reopen it after deleting the branch unfortunately.

I'm not sure whether to choose - or _ between feature words, since there's a "glow_canvas" feature in the top level Cargo.toml.

I've tested this using the custom_widget example for both iced_wgpu and iced_glow. For iced_glow I disabled default features from iced in examples/custom_widget/Cargo.toml, and then running:

cargo run --package custom_widget --no-default-features --features "glow"
cargo run --package custom_widget --no-default-features --features "glow glow_default_system_font"

@azriel91 azriel91 force-pushed the improvement/58/feature-gate-font-kit branch 3 times, most recently from 5ebef99 to df216d4 Compare May 30, 2020 07:29
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! This is exactly what I had in mind 😄

Just a couple of details and we can merge it.

CHANGELOG.md Outdated Show resolved Hide resolved
glow/src/text.rs Outdated Show resolved Hide resolved
@hecrj hecrj added feature New feature or request improvement An internal improvement labels May 30, 2020
@hecrj hecrj added this to the 0.2.0 milestone May 30, 2020
@hecrj hecrj removed the improvement An internal improvement label May 30, 2020
@azriel91 azriel91 force-pushed the improvement/58/feature-gate-font-kit branch from df216d4 to 86f0e3d Compare May 30, 2020 23:00
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you!

@hecrj hecrj merged commit d34f8e0 into iced-rs:master Jun 1, 2020
@azriel91 azriel91 deleted the improvement/58/feature-gate-font-kit branch June 1, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use something other than font-kit and/or put it behind feature gate
2 participants