Touch support #57

simlay · 2019-11-15T07:39:45Z

I've got mixed feelings about some of this - like that each touch enum has a position in it. I could have done it more similar to how the mouse events work.

I've tested the todo and tour examples on my iPhone 8 with iOS 13.2.2, the things that don't work are:

Text input (though, the cursor ends up in the text box) - I think we need to signal to winit to pop up the keyboard.
Touch scrolling on a scrollable widget. Given that the logic around cursor and touch movement not having the previous location, this didn't seem very easy to do. Fortunately, the side scrollbar works.

Here's what the tour example looks like (up to just before the rust image):

hecrj

This is awesome! Thank you 🎉

I think we should wait until rust-windowing/winit#1082 is correctly implemented for iOS before merging. Currently, the PR is rolling back winit to use the old RedrawRequested API, which causes smooth resizes to be somewhat broken on desktop. I can try to get the web backend version of winit there, but some help for iOS would be appreciated as I do not own an iOS device.

Could the positions be removed from Touch::Ended and Touch::Cancelled or can they be different from the last Touch::Moved? I am also guessing we will need to account for multiple fingers at some point, so we may need more data to identify the events in the future.

hecrj · 2019-11-15T21:40:07Z

wgpu/Cargo.toml

@@ -15,5 +15,5 @@ wgpu_glyph = { version = "0.5", git = "https://github.com/hecrj/wgpu_glyph", bra
 raw-window-handle = "0.3"
 image = "0.22"
 glam = "0.8"
-font-kit = "0.4"
+font-kit = { git = "https://github.com/simlay/font-kit", branch = "add-ios-support" }


This is waiting for servo/font-kit#110 to get merged.

hecrj · 2019-11-15T21:41:37Z

winit/src/application.rs

-
-                // TODO: Handle animations!
-                // Maybe we can use `ControlFlow::WaitUntil` for this.
-            }


We should be able to revert this once rust-windowing/winit#1082 is resolved.

cryptoquick · 2020-02-08T06:56:53Z

It looks like a lot of progress has been made since last year, how's this looking?

hecrj · 2020-02-08T19:13:46Z

Now that #181 landed, I think we can get this ready for merging.

@simlay We should rebase and remove all the merge commits. Let me know if you need any help. I could also take it to the finish line from here.

simlay · 2020-02-24T03:26:35Z

@hecrj Well, I squashed the commits (it was a pretty brutal rebase). ~~but it seems that servo/font-kit#115 font-kit has moved to using pathfinder_geometry to draw stuff which breaks the build for aarch64-apple-ios (all modern iPhones).~~

~~Looks like there's a bunch of issues similar to:~~
~~no method named `min` found for type `pathfinder_simd::scalar::I32x2` in the current scope~~

~~I might submit a PR to the pathfinding repo if it's not too hard.~~ I updated the font-kit dependency to 0.5 from crates.io. There looks to be a simd issue with some of the stuff on the github repo. This will be better anyway.

I haven't been keeping up with all the widgets this project has added since I opened the PR so I'm not sure which widgets don't have touch support.

hecrj

Looks good! Just a couple of details.

I do not think there have been any new interactive widgets. However, there is #36 which will most likely need to be adapted to also work with touch events.

native/src/widget/text_input.rs

winit/Cargo.toml

simlay · 2020-03-18T20:06:50Z

@hecrj This good to merge?

hecrj

About merging... I've given it some more thought, and I don't believe I can commit to maintaining this myself on master for the time being. Targetting the desktop and the web is already tricky enough and bringing touch events into the equation seems to complicate event processing a bit.

I could create an (even more) experimental mobile branch and we could merge this there (and maybe mention it in the README). This should allow us to explore completely different strategies for mobile (like IMEs) and I'd gladly accept PRs of anyone who wants to keep it up-to-date with master. Would you be okay with this?

Of course, there is also the possibility of you maintaining your own fork, but that may be less welcoming for new contributors!

In any case, I made some changes and turned the Touch type into a struct to unify the position and add finger data. I think it's an improvement. Let me know what you think!

valpackett · 2020-08-23T00:09:17Z

Touch is not exclusively mobile, it's definitely a thing on desktop too! (oh and IMEs are too!)

For my project (desktop dock), I can get away with pointer emulation — actually I've implemented a very particular behavior where it's clicking on release, so I can glide up from the bottom of the screen to pick an item. The usual proper touch support would be worse for this unusual application :) but customization of input handling is a separate issue, for most apps we need something like this PR.

hecrj · 2020-08-23T01:14:46Z

@myfreeweb You are completely right.

Looking back at this now, I am not sure I was being reasonable. I do not see a lot of complexity in these changes. Maybe the "mobile" part of the title scared me a bit at the time 😅

Thanks for bringing this back to my attention! I will work on getting this merged soon.

matthieugayon · 2020-11-26T20:18:04Z

Does that PR also add IOS support for iced ?
Might be totally unrelated, but is that project relevant for that PR ? And for IOS support in general ?
https://github.com/BrainiumLLC/cargo-mobile

hecrj · 2020-12-15T06:04:05Z

I think I've brought this up to speed.

I have ended up turning the Touch struct back into an enum in 3bdf931, given that this is how we handle mouse events now.

Proper support for the latest widgets is missing, but I imagine we can add that in further PRs. For instance, #650 seems to be adding touch support to the PaneGrid and the PickList. It may be interesting to rebase that PR on top of this one, once we get this merged.

I also haven't tested the changes, as I don't have a touch device at hand. I'd appreciate it if someone could try them out and report back.

hecrj

I think we can let this ship sail! We can iron out any potential issues later.

Thank you everyone! 🎉

mtsr · 2020-12-21T12:52:37Z

Great news!

hecrj reviewed Nov 15, 2019

View reviewed changes

hecrj added the feature New feature or request label Nov 15, 2019

simlay force-pushed the ios-support-wip branch 2 times, most recently from 1b484c3 to 4fba2f2 Compare November 19, 2019 18:18

simlay mentioned this pull request Nov 20, 2019

Missing platforms on docs.rs rust-windowing/winit#1028

Closed

simlay force-pushed the ios-support-wip branch from 87b89f9 to c2f9fb9 Compare November 22, 2019 17:09

hecrj added this to the 0.1.0 milestone Nov 29, 2019

simlay mentioned this pull request Dec 1, 2019

Implement revamped RedrawRequested on iOS. rust-windowing/winit#1299

Merged

8 tasks

simlay force-pushed the ios-support-wip branch 2 times, most recently from 13ff494 to 971dbde Compare February 24, 2020 03:13

simlay force-pushed the ios-support-wip branch from 971dbde to 58ec5dc Compare February 24, 2020 03:34

hecrj requested changes Mar 6, 2020

View reviewed changes

native/src/widget/text_input.rs Outdated Show resolved Hide resolved

winit/Cargo.toml Outdated Show resolved Hide resolved

simlay force-pushed the ios-support-wip branch 2 times, most recently from bcdc9e1 to eb0bbfb Compare March 18, 2020 18:24

Added initial touch events to support iOS

e19a07d

simlay force-pushed the ios-support-wip branch from eb0bbfb to e19a07d Compare March 18, 2020 18:27

hecrj added 2 commits March 19, 2020 12:17

Turn Touch into a struct and add finger id

d3572e1

Remove redundant scroll_to in Scrollable

36bdc0b

hecrj reviewed Mar 19, 2020

View reviewed changes

hecrj removed this from the 0.1.0 milestone Mar 30, 2020

hecrj mentioned this pull request Apr 2, 2020

Release 0.1 - Custom styling, event subscriptions, additional widgets, new examples, and more! #253

Merged

hecrj mentioned this pull request Apr 18, 2020

Mobile support #302

Open

hecrj closed this Jun 5, 2020

hecrj reopened this Aug 23, 2020

hecrj changed the title ~~Initial mobile touch support for iOS.~~ Touch support Aug 23, 2020

hecrj added this to the 0.2.0 milestone Aug 23, 2020

hecrj modified the milestones: 0.2.0, 0.3.0 Nov 26, 2020

matthieugayon mentioned this pull request Nov 26, 2020

iOS runtime using uikit. #631

Closed

hecrj mentioned this pull request Dec 15, 2020

Touch support for PaneGrid and PickList #650

Merged

Merge branch 'ios-support-wip' into feature/touch-support

09110a9

hecrj changed the base branch from master to 0.2 December 15, 2020 05:18

hecrj changed the base branch from 0.2 to master December 15, 2020 05:18

hecrj added 4 commits December 15, 2020 06:38

Turn Touch into a touch::Event enum

3bdf931

Change cursor position on touch event

056f7e6

Fix text selection with touch events in TextInput

70164f6

Produce logical coordinates for touch::Event

277ae74

hecrj approved these changes Dec 17, 2020

View reviewed changes

hecrj merged commit 89e604d into iced-rs:master Dec 17, 2020

hecrj mentioned this pull request Mar 31, 2021

Release 0.3 — Touch support, clipboard write access, image viewer, tooltips, and more! #806

Merged

hecrj mentioned this pull request Jan 20, 2022

how is cursor_position supposed to work with touch? #871

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Touch support #57

Touch support #57

simlay commented Nov 15, 2019

hecrj left a comment •

edited

Loading

hecrj Nov 15, 2019

hecrj Nov 15, 2019

cryptoquick commented Feb 8, 2020

hecrj commented Feb 8, 2020

simlay commented Feb 24, 2020 •

edited

Loading

hecrj left a comment

simlay commented Mar 18, 2020

hecrj left a comment •

edited

Loading

valpackett commented Aug 23, 2020

hecrj commented Aug 23, 2020 •

edited

Loading

matthieugayon commented Nov 26, 2020

hecrj commented Dec 15, 2020 •

edited

Loading

hecrj left a comment

mtsr commented Dec 21, 2020

Touch support #57

Touch support #57

Conversation

simlay commented Nov 15, 2019

hecrj left a comment • edited Loading

Choose a reason for hiding this comment

hecrj Nov 15, 2019

Choose a reason for hiding this comment

hecrj Nov 15, 2019

Choose a reason for hiding this comment

cryptoquick commented Feb 8, 2020

hecrj commented Feb 8, 2020

simlay commented Feb 24, 2020 • edited Loading

hecrj left a comment

Choose a reason for hiding this comment

simlay commented Mar 18, 2020

hecrj left a comment • edited Loading

Choose a reason for hiding this comment

valpackett commented Aug 23, 2020

hecrj commented Aug 23, 2020 • edited Loading

matthieugayon commented Nov 26, 2020

hecrj commented Dec 15, 2020 • edited Loading

hecrj left a comment

Choose a reason for hiding this comment

mtsr commented Dec 21, 2020

hecrj left a comment •

edited

Loading

simlay commented Feb 24, 2020 •

edited

Loading

hecrj left a comment •

edited

Loading

hecrj commented Aug 23, 2020 •

edited

Loading

hecrj commented Dec 15, 2020 •

edited

Loading