-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Touch support for PaneGrid
and PickList
#650
Conversation
It works ! I believe **5 - Disabled Metal Validation API ** is related to and |
I just did a PR on cargo mobile BrainiumLLC/cargo-mobile#4 |
I have also tested this on my laptop with a touchscreen, works for such devices as well! |
I have successfully resolved the conflicts in #57. I'd appreciate any feedback there! It's very likely I missed something. As I mentioned in #57 (comment), this PR seems to be adding touch support to the The idea is to merge #57 first, which includes the |
Ok got it, makes total sense, I will look into rebasing this PR on top of master (since #57 was merged) |
I'm so excited to see this work! I was tempted to investigate, also. Once this is merged in, what else would be needed to get, say, the todo list example building for mobile? |
13b73db
to
cf036c6
Compare
bc225d4
to
853b081
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for rebasing! 🎉
I have changed a bunch of minor details but everything looks good! I think we can finally merge this 🥳
Hello !
I was trying Iced and found the workflow amazing. With folks we were interested to see how it would play on iOS and, long story short, here is my take porting Simlay’s work on Touch support PR for the new 0.2 API.
Widgets are almost complete, and I can test the easy way thanks to this super cool project:
cargo-mobile
I have cool results on devices and simulators with few rough edges.
I have a small crash with font-kit and the system font loading, I worked around by using default fonts for now.
It misses the virtual keyboard management on mobile, but it is out of scope of this PR as it seems to be a winit fix as discussed on Zulip’s thread.
Here is how I could make it work in
cargo-mobile
:1 - Installed, then generated a new cargo-mobile project using the winit template.
2 - Ported one of the simplest Iced example in the lib.rs.
3 - Open the project in Xcode with
cargo apple open
.4 - Added CoreText in the list of Frameworks linked.
5 - Disabled Metal Validation API .
I’m open to give a bit of extra work here if needed!
Cheers!