Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ELCC-62: Wage Enhancements Not Included in Summary Tab Reconcilation Expence Column #83

Conversation

klondikemarlen
Copy link
Member

@klondikemarlen klondikemarlen commented Oct 2, 2024

Fixes https://yg-hpw.atlassian.net/browse/ELCC-62

Relates to:

Context

User Report

I went in today and started inputting data into the 23/24 sheet for Bright Stars.
I noticed: 5. Only benefit section costing is tabulated under employee expenses - so balance isn’t accurate

Summary -> Reconciliation sub-tab -> Expenses column is not supposed to include Wage Enhancements or Employee Benefits.
Wage Enhancements and Employee Benefits are supposed to go in the Employees column instead.

Reproduction Instructions

  1. Go to the http://localhost:8080/child-care-centres page.
  2. Select a Child Care Centre by double-clicking on it, or adding a new one via the top right call-to-action.
  3. Select the 2023/24 fiscal year from top right selector thing.
  4. Go to the "Summary" tab.
  5. Note down the value of the "April" expenses.
  6. Go to the "Employees" tab.
  7. Scroll down to the "Wage Enhancements" Section.
  8. Across from the Level 1 wage enhancement click the "+" icon.
  9. Add your name, and 35 for estimated hours.
  10. Click the "flopy disk" icon to save.
  11. Scroll down to the bottom of the section and note down the "Section Total" for the estimate.
  12. Go back to the "Summary" tab.
  13. Note that the "April" expense of the "Reconciliation" sub-tab includes the Section Total in the "Expense" column, instead of the "Employees" column.
  14. Go back to the "Employees" tab.
  15. Scroll down to the "Wage Enhancements" Section.
  16. Scroll down to the entry you added an estimate for.
  17. Add a value for the actual of 38 hours.
  18. Scroll down to the bottom and click the save button.
  19. Note down the Section Total for the actual value.
  20. Go back to the "Summary" tab.
  21. Note that the "April" expense of the "Reconciliation" sub-tab includes the Section Total in the "Expense" column, instead of the "Employees" column.

Implementation

  1. Move the computation to the correct column.
  2. Fix some rendering issues around "this amount includes estimated values" tooltip.
  3. Use better row striping technique from Travel Auth project.

Screenshots

Worksheet Summary Reconciliation With Employee Expenses in the correct column.
http://localhost:8080/child-care-centres/1/2022-23/summary/reconciliation
image

Testing Instructions

  1. Boot the app via dev up
  2. Check that the app complies, and that you can log in at http://localhost:8080.
  3. Go to the http://localhost:8080/child-care-centres page.
  4. Select a Child Care Centre by double-clicking on it, or adding a new one via the top right call-to-action.
  5. Select the 2023/24 fiscal year from top right selector thing.
  6. Go to the "Summary" tab.
  7. Note down the value of the "April" expenses.
  8. Go to the "Employees" tab.
  9. Scroll down to the "Wage Enhancements" Section.
  10. Across from the Level 1 wage enhancement click the "+" icon.
  11. Add your name, and 35 for estimated hours.
  12. Click the "flopy disk" icon to save.
  13. Scroll down to the bottom of the section and note down the "Section Total" for the estimate.
  14. Go back to the "Summary" tab.
  15. Check that the "April" row "Reconciliation" sub-tab includes the Section Total in the "Employees" column
  16. Go back to the "Employees" tab.
  17. Scroll down to the "Wage Enhancements" Section.
  18. Scroll down to the entry you added an estimate for.
  19. Add a value for the actual of 38 hours.
  20. Scroll down to the bottom and click the save button.
  21. Note down the Section Total for the actual value.
  22. Go back to the "Summary" tab.
  23. Check that the "April" row "Reconciliation" sub-tab includes the Section Total in the "Employees" column.

…ciliation page.

Issue primarily was that parent component was missing possition: relative.
The rest of the fixes, are me taking advantage of better Vuetify 3 options.
Previous style worked in Vuetify 2.
@klondikemarlen klondikemarlen added the bug Something isn't working label Oct 2, 2024
@klondikemarlen klondikemarlen self-assigned this Oct 2, 2024
@klondikemarlen klondikemarlen force-pushed the elcc-62/wage-enhancements-not-included-in-summary-tab---reconcilation---expence-column branch from 3ddef69 to 46996bd Compare October 2, 2024 22:29
@klondikemarlen klondikemarlen marked this pull request as ready for review October 2, 2024 22:38
@klondikemarlen klondikemarlen merged commit 7a3ae3e into main Oct 2, 2024
@klondikemarlen klondikemarlen deleted the elcc-62/wage-enhancements-not-included-in-summary-tab---reconcilation---expence-column branch October 2, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant