forked from ytgov/elcc-data-management
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ELCC26: Navigation Enhancement #86
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure why this works. I copied this from https://github.com/icefoganalytics/wrap and seems to make VSCode happy.
What? The FundingSubmissionLineJson model has a "virtual" field for "lines".
…orksheetsMonthlyWorksheetPage.
Pattern is pages/url/segment/ComponentName.vue e.g. /child-care-centres/1/2024-25/worksheets/may -> pages/child-care-centres/fiscal-years/worksheets/MonthlyWorksheetPage.vue Note: /child-care-centres/1/2024-25/worksheets/may should probably be /child-care-centres/some-center-slug/fiscal-years/2024-25/worksheets/may
…age. Why? To make it easier to find page components.
My linter now tells me about this kind of stuff 🎉!
Move component to a model based location for easier re-use.
NOTE: navigation only triggers when at the beginning or end of input text.
NOTE: this only works for "enter" due to the nature of the arrow events.
Arrow navigation on a selected text now drops the selection and moves to the beginning or end of the text.
This style was missed when splitting the edit sheet out from the main page.
Why? To make it easier for users to figure out the keyboard shortcuts available.
It's good for modals state and table queries stored in the url.
Why? Accessibility and ease of debugging and texting.
Why? To get AI auto-completion as I type. Taken from icefoganalytics/travel-authorization@1d1dd56
klondikemarlen
force-pushed
the
elcc-26/navigation-enhancement
branch
from
October 4, 2024 23:43
02d576e
to
e2a14a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://yg-hpw.atlassian.net/browse/ELCC-26
Context
Is there an easier way to move down to the next cell to fill? Tab you have to go through est first, enter and arrows don’t work.
It sounds like there are limited ways of moving in and out of cells (TAB). Is it possible to enable the ability to use enter and arrows to navigate? Currently it is taking a considerable amount of time to navigate screens to enter data.
Implementation
dev edit-pr <github-pr-url>
helper from Travel Auth project to get AI auto-completion as I type PR instructions.Screenshots
Keyboard Shortcuts Modal
Testing Instructions
dev up