⌨️ #1098 Add Data Center fields #2754
Conversation
…to feat/1098-dataCenter-fields
demariadaniel
changed the title
demariadaniel
changed the title
| * if using a shortName format that is not "NAME-AREA", a working example is "BOB-CA" | ||
| * using cancerTypes or countries that doesn't exist or is not in the same format as the database ex. a working example of cancerTypes is "Lung cancer". Bad example are "lung", "lung cancer" | ||
| * admin's email must be in an email format ex. use @ | ||
| */ |
There was a problem hiding this comment.
If you added this comment to the file directly , it will be deleted when types re-generate
There was a problem hiding this comment.
This comment lives in the API and Daniel wrote it while he was here
I did not add it myself, gql_types has already been generated by running gql:codegen
There was a problem hiding this comment.
excellent! I didn't know it kept comments, that's great to know.
| submissionSongCode | ||
| submissionSongUrl | ||
| submissionScoreUrl | ||
| } |
There was a problem hiding this comment.
this feels off. Why are we sending all these urls to the frontend when our architecture is using gateways?
There was a problem hiding this comment.
Great question, I agree however this is just the UI requesting all Data Center related fields
The URLs will have to be removed upstream @ the API GQL type and I will have to ask if this can be changed
Worth investigating before merging
There was a problem hiding this comment.
None of these fields are required so they can be removed from FE query, just going to confirm their intent on Slack
There was a problem hiding this comment.
Removed based on Slack discussion, not needed for UI
| submissionSongCode | ||
| submissionSongUrl | ||
| submissionScoreUrl | ||
| } |
There was a problem hiding this comment.
I think these can be removed too
There was a problem hiding this comment.
Oops, sorry, removed
Description of changes
Adds DataCenter fields to UI pages & Queries (especially Create / Update Program)
Related API Changes: icgc-argo/platform-api#717
Screenshots: https://app.zenhub.com/workspaces/icgc-argo-platform-dk-production-board-5e542d38415f5034e9fed89d/issues/gh/icgc-argo/roadmap/1098
Type of Change
Checklist before requesting review