-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⌨️ #1098 Add Data Center fields #2754
Changes from all commits
835ef8f
9205728
f6d899e
9edb4f1
66970bd
d9f383f
f55d917
7112ff1
8defe10
c64ed0b
ca0bdba
e44042e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,6 +43,11 @@ const PROGRAM_QUERY = gql` | |
inviteAcceptedAt | ||
inviteStatus | ||
} | ||
dataCenter { | ||
id | ||
shortName | ||
name | ||
} | ||
} | ||
} | ||
`; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,6 +30,11 @@ const PROGRAMS_LIST_QUERY = gql` | |
genomicDonors | ||
submittedDonors | ||
commitmentDonors | ||
dataCenter { | ||
id | ||
shortName | ||
name | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this feels off. Why are we sending all these urls to the frontend when our architecture is using gateways? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Great question, I agree however this is just the UI requesting all Data Center related fields There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. None of these fields are required so they can be removed from FE query, just going to confirm their intent on Slack There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed based on Slack discussion, not needed for UI |
||
} | ||
} | ||
`; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -848,6 +848,7 @@ export type Program = { | |
cancerTypes?: Maybe<Array<Maybe<Scalars['String']>>>; | ||
commitmentDonors?: Maybe<Scalars['Int']>; | ||
countries?: Maybe<Array<Maybe<Scalars['String']>>>; | ||
dataCenter?: Maybe<DataCenter>; | ||
description?: Maybe<Scalars['String']>; | ||
genomicDonors?: Maybe<Scalars['Int']>; | ||
institutions?: Maybe<Array<Maybe<Scalars['String']>>>; | ||
|
@@ -1050,11 +1051,19 @@ export type ProgramDonorSummaryStats = { | |
sangerStatusCount: WorkflowStatusCount; | ||
}; | ||
|
||
/** | ||
* ProgramInput will throw a bad user input error in the following cases: | ||
* if using name that is already in the database, | ||
* if using a shortName format that is not "NAME-AREA", a working example is "BOB-CA" | ||
* using cancerTypes or countries that doesn't exist or is not in the same format as the database ex. a working example of cancerTypes is "Lung cancer". Bad example are "lung", "lung cancer" | ||
* admin's email must be in an email format ex. use @ | ||
*/ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you added this comment to the file directly , it will be deleted when types re-generate There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This comment lives in the API and Daniel wrote it while he was here There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. excellent! I didn't know it kept comments, that's great to know. |
||
export type ProgramInput = { | ||
admins: Array<ProgramUserInput>; | ||
cancerTypes: Array<InputMaybe<Scalars['String']>>; | ||
commitmentDonors: Scalars['Int']; | ||
countries: Array<Scalars['String']>; | ||
dataCenter?: InputMaybe<Scalars['String']>; | ||
description?: InputMaybe<Scalars['String']>; | ||
institutions: Array<Scalars['String']>; | ||
membershipType: MembershipType; | ||
|
@@ -1068,6 +1077,7 @@ export type ProgramOptions = { | |
__typename?: 'ProgramOptions'; | ||
cancerTypes: Array<Maybe<Scalars['String']>>; | ||
countries: Array<Maybe<Scalars['String']>>; | ||
dataCenters: Array<Maybe<DataCenter>>; | ||
institutions: Array<Maybe<Scalars['String']>>; | ||
primarySites: Array<Maybe<Scalars['String']>>; | ||
}; | ||
|
@@ -1080,7 +1090,7 @@ export type ProgramUser = { | |
inviteStatus?: Maybe<InviteStatus>; | ||
isDacoApproved?: Maybe<Scalars['Boolean']>; | ||
lastName: Scalars['String']; | ||
role: UserRole; | ||
role?: Maybe<UserRole>; | ||
}; | ||
|
||
export type ProgramUserInput = { | ||
|
@@ -1203,6 +1213,11 @@ export type QueryProgramDonorSummaryArgs = { | |
}; | ||
|
||
|
||
export type QueryProgramsArgs = { | ||
dataCenter?: InputMaybe<Scalars['String']>; | ||
}; | ||
|
||
|
||
export type QueryQueryArgs = { | ||
query?: InputMaybe<Scalars['String']>; | ||
types?: InputMaybe<Array<InputMaybe<Scalars['String']>>>; | ||
|
@@ -1312,6 +1327,7 @@ export type UpdateProgramInput = { | |
cancerTypes?: InputMaybe<Array<InputMaybe<Scalars['String']>>>; | ||
commitmentDonors?: InputMaybe<Scalars['Int']>; | ||
countries?: InputMaybe<Array<InputMaybe<Scalars['String']>>>; | ||
dataCenter?: InputMaybe<Scalars['String']>; | ||
description?: InputMaybe<Scalars['String']>; | ||
institutions?: InputMaybe<Array<InputMaybe<Scalars['String']>>>; | ||
membershipType?: InputMaybe<MembershipType>; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these can be removed too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, sorry, removed