Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test suite has tests relying on a bug in libMesh all_second_order() #26060

Closed
roystgnr opened this issue Nov 14, 2023 · 1 comment
Closed

Test suite has tests relying on a bug in libMesh all_second_order() #26060

roystgnr opened this issue Nov 14, 2023 · 1 comment
Labels
P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@roystgnr
Copy link
Contributor

Bug Description

Some tests combine generation of a mesh with non-full-order second-order elements (e.g. HEX20) with the MOOSE option second_order=true, which uses all_second_order() to request that all elements in a mesh be converted into their full-order second-order equivalents (e.g. a HEX27 instead of a HEX20)

libMesh currently has a bug where, even if asked for full-order elements, it ignores non-full-order second-order elements. Fixing that bug creates exodiffs in these tests.

Steps to Reproduce

libMesh/libmesh#3707 triggers the failures.

Impact

This is blocking the bug fix, but fixing it should be as simple as removing second_order=true from those tests.
@roystgnr roystgnr added T: defect An anomaly, which is anything that deviates from expectations. P: normal A defect affecting operation with a low possibility of significantly affects. labels Nov 14, 2023
roystgnr added a commit to roystgnr/moose that referenced this issue Nov 14, 2023
@roystgnr
Don't ask to make a HEX20 second_order=true
d58b56b 
There's currently a bug in libMesh wherein if you ask to
`all_second_order()` a mesh, with `full_order=true`, it will
ignore existing second-but-not-full-order elements.  These tests were
relying on that buggy behavior.

Refs idaholab#26060 ... and hopefully fixes it; I'm still looking for other bad
tests elsewhere.
@roystgnr roystgnr mentioned this issue Nov 14, 2023
Merged
@roystgnr
Copy link
Contributor Author

After #26061 we're not hitting any more tests with the same problem.

pbehne pushed a commit to pbehne/moose that referenced this issue Dec 1, 2023
@roystgnr @pbehne
Don't ask to make a HEX20 second_order=true
33de01a 
There's currently a bug in libMesh wherein if you ask to
`all_second_order()` a mesh, with `full_order=true`, it will
ignore existing second-but-not-full-order elements.  These tests were
relying on that buggy behavior.

Refs idaholab#26060 ... and hopefully fixes it; I'm still looking for other bad
tests elsewhere.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@roystgnr