Don't ask to make a HEX20 second_order=true #26061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's currently a bug in libMesh wherein if you ask to `all_second_order()` a mesh, with `full_order=true`, it will ignore existing second-but-not-full-order elements. These tests were relying on that buggy behavior. Refs idaholab#26060 ... and hopefully fixes it; I'm still looking for other bad tests elsewhere.
lindsayad
approved these changes
Nov 14, 2023
|
Job Documentation on d58b56b wanted to post the following: View the site here This comment will be updated on new commits. |
|
Job Coverage on d58b56b wanted to post the following: Framework coverageCoverage did not change Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's currently a bug in libMesh wherein if you ask to
all_second_order()a mesh, withfull_order=true, it will ignore existing second-but-not-full-order elements. These tests were relying on that buggy behavior.Refs #26060 ... and hopefully fixes it; I'm still looking for other bad tests elsewhere.